Giter Club home page Giter Club logo

Comments (5)

gwenn avatar gwenn commented on June 19, 2024

#1270 (comment)

the compiled version of SQLite inside of Windows is only meant to be used by projects that are bundled as part of the Windows operating system ( microsoft/win32metadata#824 (comment)), not non-Microsoft projects.

from rusqlite.

bdbai avatar bdbai commented on June 19, 2024

@gwenn

Thanks for pointing it out. CMIIW, I think the statement you are quoting does not come from an official source or documentation that Microsoft claims?

Regarding the comment microsoft/win32metadata#824 (comment), maybe someone misinterprets it here?

Windows ships a compiled version of SQLite in System32/winsqlite3.dll that certain OS projects depend on. If you want to use this version to reduce your overall binary size, you can link against this version instead of compiling it directly into your own project.
I don't recommend that for non-OS projects, but that's where it comes from. @jonwis may have some guidance here.

AFAIK it just looks like some kind of personal preference, instead of an official announcement of the direction that winsqlite3 in Windows is going to follow. link against this version instead of compiling it directly into your own project is still an option.

Well I understand that it might be a maintenance burden given few people use it. Now that winsqlite is already implemented and shipped in stable releases, I would suggest still keeping the option to use winsqlite and remove only the tests, and then let those who need it to test it out.

from rusqlite.

bdbai avatar bdbai commented on June 19, 2024

For your reference, winsqlite3 is also available as a provider of the .NET library Microsoft.Data.Sqlite.

https://learn.microsoft.com/en-us/dotnet/standard/data/sqlite/custom-versions?tabs=netcore-cli

from rusqlite.

gwenn avatar gwenn commented on June 19, 2024

@davidbarsky, @thomcc
Could you please advise ?

from rusqlite.

davidbarsky avatar davidbarsky commented on June 19, 2024

@davidbarsky, @thomcc

Could you please advise ?

I can't reasonably advise, but the fact that feature flag has bitten me when vendoring crates into a monorepo will remain a risk if it returns.

As a person consuming this library (but not necessarily using it), the RUSTFLAGS approach I mentioned in the original issue won't cause me or my employer much difficulty or risk. That being said, I think the .NET team will have substantially more viability into what version of sqlite version will be bundled into Windows than me, so I'm not exactly qualified to opine.

from rusqlite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.