Comments (11)
I’m currently testing my patch before opening a new PR. What do you think?
The version before #300 worked fine for my local machine and on Travis machines. The #300 patch seems to be fine there too. So it's hard to say :)
from polly.
I made a PR lately to fix a weird signing issue with the ios-nocodesign-* toolchains. While it worked on pretty much all of our CI jobs, one failed when CMake tried to check whether the compiler was okay
It does make sense to save the error message that you have for the history. What error message was before the #300 was applied and what error message do you have now?
from polly.
Prior to #300, we had the binary on simulation
signed and we had to manually remove the signature after the build. After #300, we had this:
-- Check for working C compiler: /Applications/Xcode-10.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -- broken
CMake Error at /usr/local/Cellar/cmake/3.13.2/share/cmake/Modules/CMakeTestCCompiler.cmake:52 (message):
The C compiler
"/Applications/Xcode-10.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang"
is not able to compile a simple test program.
…
builtin-productPackagingUtility -entitlements -format xml -o /Users/distiller/****/CMakeFiles/CMakeTmp/CMAKE_TRY_COMPILE.build/Debug-iphonesimulator/cmTC_235b1.build/cmTC_235b1.app-Simulated.xcent
warning: Falling back to contents of entitlements file """" because it was modified during the build process. Modifying the entitlements file during the build is unsupported.error: The file “""” couldn’t be opened because there is no such file.
** BUILD FAILED **
from polly.
I confirm my patch fixes it. I’ll do another PR if you want.
from polly.
Prior to #300, we had the binary on simulation signed and we had to manually remove the signature after the build.
Can you post step by step instructions with all details: CMake version, Polly toolchain, Xcode version, log with sign instruction line, the code itself.
from polly.
Hello,
I’m not sure what to do with the details since it’s code from work. It’s open-source though so I guess it should be okay. I’m adding @KhalilBellakrid and @pollastri-pierre to the discussion for this purpose.
The failible job can be found here.
from polly.
I’m not sure what to do with the details since it’s code from work.
There is no need to show the whole project, of course only minimal example would be nice to have.
The failible job can be found here.
Okay, at least some info :) It's Xcode 10 and we are failing while checking that C compiler is not broken.
from polly.
Yes, and I think it’s due to the empty entitlements. I only a few about iOS, so I wrote a sed
line to fix that in our circle-ci job. I just wanted you to know. :)
from polly.
I've added iOS tests to CI: b14ab7b
CMake 3.13.2, ios-nocodesign-11-4-dep-9-3-armv7
, Xcode 9.4.1:
CMake 3.13.2, ios-nocodesign-12-1-dep-9-3-armv7
, Xcode 10.1:
The failible job can be found here.
I've noticed that you've used this line:
-G Xcode -DCMAKE_BUILD_TYPE:STRING=Release -DBUILD_TESTS=OFF
-DCMAKE_OSX_ARCHITECTURES:STRING=x86_64 -DCMAKE_MACOSX_BUNDLE:BOOL=ON
-DCMAKE_OSX_SYSROOT:STRING=iphonesimulator -DCMAKE_TOOLCHAIN_FILE=/Users/distiller/lib-ledger-core/toolchains/polly/ios-nocodesign-11-2-dep-9-3.cmake
CMAKE_OSX_ARCHITECTURES
and CMAKE_OSX_SYSROOT
should not be used here. If you want to limit architectures to 64 bit variants then you should use another toolchain like ios-10-3-dep-9-3-x86-64-arm64
. Also last time I've tried simulator-only toolchain I had CMake issues, so all Polly toolchains with simulator have ARM-device part.
from polly.
Interesting, thanks for your feedback!
from polly.
Closing inactive discussion.
from polly.
Related Issues (20)
- mingw cross compilation from Linux to Windows HOT 9
- CHECK_TYPE_SIZE iOS error HOT 4
- Clang Compiler Test Failing For iOS-10-3-armv7.cmake At Master Commit 3e3f903 HOT 21
- SwiftModule and -Swift.h ObjC compatibility header not copied to framework HOT 7
- xcode8 ios automatic provisioning HOT 1
- Additional C flags required for static-std.cmake to fix behaviour change in CMake HOT 1
- Problem codesigning iOS 11.2 with Xcode 9.2 (9C40b) HOT 5
- build details (active)
- reason for clearing IPHONEOS_DEPLOYMENT_TARGET HOT 4
- How to start for iOS? HOT 4
- --framework fails on codesign for multiple iPhone Developer certificate HOT 3
- ANDROID_NDK_rXX not set HOT 4
- Build failure on latest XCode (10A255) HOT 6
- add support for qnx HOT 2
- colorized ouput HOT 5
- "/usr/bin/ld: cannot find -lc++" when using the clang-lto toolchain file HOT 2
- How to reduce Xcodebuild log size? HOT 4
- Add support for Apple's Project Catalyst HOT 2
- Problem with CPack HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from polly.