Giter Club home page Giter Club logo

Comments (21)

joeced avatar joeced commented on June 20, 2024 1

@ruslo @Casz A simpler solution would be to change the set(MACOSX_BUNDLE_GUI_IDENTIFIER com.example.polly) in every ios*.cmake file, and the update the docs. I will gladly provide a pull request for this. Eventually refactoring to extract the # fix try_compile part.

from polly.

MrJman006 avatar MrJman006 commented on June 20, 2024

For simplicity sake, I just tried a bare minimum CMake project

cmake_minimum_required(VERSION 3.8)
project(foo)

and get the same error.

from polly.

ruslo avatar ruslo commented on June 20, 2024

and get the same error

Nothing I can recommend here except fixes from documentation:

If you'll find the fix feel free to add it to docs.

from polly.

joeced avatar joeced commented on June 20, 2024

I'm working on a fix. You need to set the MACOSX_BUNDLE_GUI_IDENTIFIER to something different. For me setting it to com.<company-name>.example worked.

@ruslo What I'm considering a is fix of the try-compile introducing a POLLY_XCODE_BUNDLE_IDENTIFIER variable that can be set from an environment variable. Does this sound like a reasonable solution?

from polly.

ruslo avatar ruslo commented on June 20, 2024

@joeced Are you sure that while doing these steps your team-id is the same as you used in POLLY_IOS_DEVELOPMENT_TEAM?

from polly.

joeced avatar joeced commented on June 20, 2024

@ruslo Yes most definitely. The problem is that we are not allowed to use com.example as bundle identifier, it will fail with the error:

No profiles for ´com.example´ were found: Xcode couldn't find a
provisioning profile matching ´com.example´.

Code signing is required for product type ´Application´ in SDK ´iOS 10.3´

If I

set(MACOSX_BUNDLE_GUI_IDENTIFIER com.<my company name>.example)

it works!

from polly.

ruslo avatar ruslo commented on June 20, 2024

The problem is that we are not allowed to use com.example as bundle identifier

Is it a limitation of your provisioning profile?

from polly.

joeced avatar joeced commented on June 20, 2024

Step set the bundle id to com.example in signing-request-development-team fails for me.
xcode screenshot
The problem being that another team in my organization used com.example as bundle identifier at some point in time. I'm on another enterprise account. Hope this clarifies the problem.

Addition:
I just realized this might not have been @MrJman006 original problem. Sorry, for littering the issue with unrelated comments. The problem still persists though.

from polly.

jetersen avatar jetersen commented on June 20, 2024

@joeced @ruslo
Checked our appstore and enterprise team and there is no com.example
Think the issue properly lies with the fact it is an enterprise account, apple doesn't allows creating bundle identifiers used by other enterprise account.
As I am able to use the com.example in our appstore team but not our enterprise team.

But it is definitely an issue we see with our enterprise account.

from polly.

ruslo avatar ruslo commented on June 20, 2024

The problem being that another team in my organization used com.example as bundle identifier at some point in time. I'm on another enterprise account. Hope this clarifies the problem.

@joeced No, I'm not sure I undestand that. This stuff is quite opaque to me :) I hope to find clear and simple way to use/set this ID. At this moment iOS toolchains was working for completely unrelated teams and developers.

apple doesn't allows creating bundle identifiers used by other enterprise account

@Casz Can you clarify this? Can we check whom to blame and how to fix/workaround this. Even if POLLY_IOS_BUNDLE_IDENTIFIER will be introduced, there is a chance that same issue will appear again. What the difference here between com.example and com.mycompany?

from polly.

jetersen avatar jetersen commented on June 20, 2024

@ruslo I can try.

On our enterprise team:
I am not able to generate provisioning profiles for the following.
com.abc
com.bob
com.example
com.cnn
com.starwars

However I am able to type random stuff after those previously blocked
com.asdasjdksdjn
com.abc.helloworld9231
com.starwars.helloworld9231

On our appstore team it is not an issue at all.

Now with the ability to set POLLY_IOS_BUNDLE_IDENTIFIER it doesn't have to be com.example but com.example.helloworld9231

obviously com.widex or com.widex.anything will also work

from polly.

ruslo avatar ruslo commented on June 20, 2024

On our enterprise team:
I am not able to generate provisioning profiles for the following.
com.abc
com.bob
com.example
com.cnn
com.starwars

@Casz Do you know what is the reason?

A simpler solution would be to change the set(MACOSX_BUNDLE_GUI_IDENTIFIER com.example.polly) in every ios*.cmake file, and the update the docs. I will gladly provide a pull request for this. Eventually refactoring to extract the # fix try_compile part.

@joeced Okay, we can try it.

from polly.

jetersen avatar jetersen commented on June 20, 2024

@ruslo other than this error message below. I cannot.

The app ID "com.example" cannot be registered to your development team. Change your bundle identifier to a unique string to try again.

xcode error

from polly.

ruslo avatar ruslo commented on June 20, 2024

Sorry guys I still don't see the reason of the failure.

The app ID "com.example" cannot be registered to your development team. Change your bundle identifier to a unique string to try again

Where is the guarantee that we will not have same error for com.example.polly?

from polly.

jetersen avatar jetersen commented on June 20, 2024

Nothing, at all.
At least it fixes it for enterprise accounts for now.
I do not see any harm in the PR.

You want us to explain the inner workings of Xcode and Apple Developer Portal for Enterprise Accounts.
Which I cannot. Sadly, it is closed source.

What gives?

My best guess is there is a slight difference towards how uniqueness is handled on the enterprise bundle identifier for Apple Developer Portal.

Since for Apple App store all apps are re-signed by Apple and assigned to a team. Where on the Enterprise account, each bundle is unique when you want to distribute with your app.

from polly.

jetersen avatar jetersen commented on June 20, 2024

If you want a permanent fix. Let's introduce POLLY_IOS_BUNDLE_IDENTIFIER and have it default to the com.example or even com.example.polly when it is not set.

from polly.

ruslo avatar ruslo commented on June 20, 2024

What I'm considering a is fix of the try-compile introducing a POLLY_XCODE_BUNDLE_IDENTIFIER variable that can be set from an environment variable. Does this sound like a reasonable solution?

If you want a permanent fix. Let's introduce POLLY_IOS_BUNDLE_IDENTIFIER and have it default to the com.example or even com.example.polly when it is not set.

Okay, probably this one is better. At least we can be sure that it will not break iOS build for other developers.

from polly.

ruslo avatar ruslo commented on June 20, 2024

As a sidenote this problem can be fixed in CMake itself by adding no-code-sign logic for iOS internals.

from polly.

jetersen avatar jetersen commented on June 20, 2024

As a sidenote this problem can be fixed in CMake itself by adding no-code-sign logic for iOS internals.

Which might be the better solution

from polly.

ruslo avatar ruslo commented on June 20, 2024

Fixed by #173

from polly.

ruslo avatar ruslo commented on June 20, 2024

Step by step document with screenshots:

from polly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.