runyan-co / code-test Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 0.0 2.16 MB

Laravel and Vue.js code test for ProcessMaker.

Shell 0.14% PHP 13.59% Blade 0.10% Vue 2.35% HTML 83.81%

code-test's People

Contributors

Stargazers

code-test's Issues

Improvement here would be form validation prior to firing off the request

code-test/public/js/bundle.js

Lines 418 to 423 in 3c2e235

 // todo Improvement here would be form validation prior to firing off the request 

 return _context3.abrupt("return", axios.post("/api/record/update/".concat(_this6.$refs.form.id), _this6.$refs.form.form)); 

 case 2: 

 case "end":

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

Can be significantly improved by translating returned error message back into al...

code-test/public/js/bundle.js

Lines 349 to 354 in 3c2e235

 // todo Can be significantly improved by translating returned error message back into alerts/toasts for the user to see 

 _this2.editModal.errorMessage = 'An error occurred while trying to update this record.'; 

 _this2.editModal.error = true; 

 }); 

 }, 

 getRecords: function getRecords() {

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

Showing a more specific error message from the backend would be better here

code-test/public/js/bundle.js

Lines 319 to 324 in 3c2e235

 // todo Showing a more specific error message from the backend would be better here 

 _this.editModal.error = true; 

 _this.editModal.errorMessage = 'An error occurred while trying to delete this record.'; 

 }); 

 })["catch"](function (e) {}); 

 },

runyan-co / code-test Goto Github PK

code-test's People

Contributors

Stargazers

code-test's Issues

Improvement here would be form validation prior to firing off the request

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

Can be significantly improved by translating returned error message back into al...

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

Showing a more specific error message from the backend would be better here

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// todo Improvement here would be form validation prior to firing off the request

	return _context3.abrupt("return", axios.post("/api/record/update/".concat(_this6.$refs.form.id), _this6.$refs.form.form));

	case 2:
	case "end":

	// todo Can be significantly improved by translating returned error message back into alerts/toasts for the user to see
	_this2.editModal.errorMessage = 'An error occurred while trying to update this record.';
	_this2.editModal.error = true;
	});
	},
	getRecords: function getRecords() {

	// todo Showing a more specific error message from the backend would be better here
	_this.editModal.error = true;
	_this.editModal.errorMessage = 'An error occurred while trying to delete this record.';
	});
	})["catch"](function (e) {});
	},

runyan-co / code-test Goto Github PK

code-test's People

Contributors

Stargazers

code-test's Issues

This issue was generated by todo based on a todo comment in 3c2e235. It's been assigned to @runyan-co because they committed the code.

This issue was generated by todo based on a todo comment in 3c2e235. It's been assigned to @runyan-co because they committed the code.

This issue was generated by todo based on a todo comment in 3c2e235. It's been assigned to @runyan-co because they committed the code.

Recommend Projects

Recommend Topics

Recommend Org

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.

This issue was generated by todo based on a `todo` comment in `3c2e235`. It's been assigned to @runyan-co because they committed the code.