runfinch / finch-core Goto Github PK

Whats going on?

We don’t have automation to build dependencies necessary to support virtualization framework in finch.

• finch-core builds the dependencies of finch via a github action.
• finch-core builds the dependencies on the minimum OS version supported by finch which is macOS 11
• Virtualization framework has a requirement to build limactl binary on macOS 13 as that is the minimum supported OS version for lima to support virtualization framework.
• We don’t have a workflow which builds limactl binary on macOS13 and the rest on macOS11.

Create a workflow that generates limactl dependency on macOS 13 and adds it to the dependency distribution.

Hitting some test failures when running tests on PRs, so I will compile a list of all E2E test failures and examples when running CI.

• Timeout failure in SynchronizedBeforeSuite
  • macos 13, x86
• Load/save image test failure
  • macos 12, x86
  • macos 13, arm
  • macos 12, arm

This repo doesn't have a CONTRIBUTING.md file and it is referenced in the PR Template.

Hermit pretty much does what this repo does but is multi OS /Arch and is golang

https://github.com/cashapp/hermit

the docs and example repo that stores the binary references says it all

it also gives you a hermatic build : dev environment . It’s containerised , without using containers , by taking over the shell .

Works in ci too

The Build action has been consistently failing for the last month: https://github.com/runfinch/finch-core/actions/workflows/release.yaml

The log lines in step Make and release deps before timeout have been:

if [ "Darwin" != "Linux" -a ! -e "/opt/homebrew/bin/nerdctl" ]; then ln -sf nerdctl.lima "/opt/homebrew/bin/nerdctl"; fi
if [ "Darwin" != "Linux" -a ! -e "/opt/homebrew/bin/apptainer" ]; then ln -sf apptainer.lima "/opt/homebrew/bin/apptainer"; fi
sudo may prompt for password to run FileMonitor
Error: The operation was canceled. # <-- timeout, cancelled workflow

This message is coming from

Still looking to verify but the smoking gun is that the script is hanging on a prompt for password.

e: On my machine macOS Ventura 13.4 M1 chip:

./bin/lima-and-qemu.pl                                            
ls: /opt/homebrew/bin/limactl: No such file or directory
Missing argument in sprintf at ./bin/lima-and-qemu.pl line 213.
sudo may prompt for password to run FileMonitor
Password: