runemoro / better-renderer Goto Github PK

So, uh... I'm getting a CTD with the current build (a8cd162) of the BetterRenderer plugin. It occurs at startup, before I even login. Previous builds ran well enough, but I'm unable to get the client running with this one.

Here are the launcher, client, and crash logs:

launcher.log
client.log
jvm_crash_pid_12896.log

And if needed, here is a short clip demonstrating it: https://cdn.discordapp.com/attachments/689215119498018883/777386984942338088/Desktop_2020.11.15_-_04.17.08.02.mp4

On an additional note, you can see in that clip that the client appears to ... 'break' and scale weirdly, then refuse to maximise properly, before it crashes. If I disable your plugin and enable the official RuneLite gpu one, this does not happen and it behaves as expected. Here is a clip I recorded of that as well: https://cdn.discordapp.com/attachments/689215119498018883/777388477863297034/Desktop_2020.11.15_-_04.23.10.03.mp4

If you need any more information, please let me know.

I'm curious by bzip2 was chosen as it is a rather poor compression algorithm, cite.

Would you be willing to consider switching? I would happily do some of the leg work on this. I was eying zstd, but it would require using the JNI, is that prohibited in runelite?

Are there any plans to try to get the game too look less bright?


Personally the game looks way to bright, im loving everything else though. I hope this is something that can be changed / fixed in the future.

When I try and use the plugin I get a message about downloading the cache, thats as far as I get. Any ideas?

Hello this was inside the raid. Outside the render was off as well I tried with zoom off and on but it was hard to click on the entrance for example

Worse FPS then GPU plugin, anyway to make the plugin maybe utilize more of the gpu and if that happens
Couldn't you unlimit the cameras fps in the render to support 144hz + screens?
I remember seeing a jagex post saying something about that

love the plugin so far just wondering if i have done something wrong to be rendering of poh floor is completely blacked out by heavy darkness as long as zulrah lair

It stays at saying "downloading game cache, this may take a few minutes" and never actually turns on.

Hello I was testing the plugin a bit with the zoom off/on and in fixed mode at sire the render seems to be off. Any location I click on the map does not move me to that location. I posted

here on discord. Hope it helps love the plugin it looks amazing the plugin does work as expected in resizeable mode which is great. Thank you for reading

I suggest using the cache module of runelite itself.

Something along the lines of:

	public void dumpCache() throws IOException
	{
		Store store = new Store(DEFAULT_CACHE_DIR);
		store.load();
		Storage storage = store.getStorage();
		store.getIndexes().forEach(index ->
		{
			log.debug("Dumping index " + (index.getId() + 1) + "/20");
			index.getArchives().forEach(archive ->
			{
				try
				{
					byte[] archiveData = storage.loadArchive(archive);
					if (index.getId() == 5)
					CacheFiles.write(index.getId(), archive.getArchiveId(), archiveData);
					else
					{
						archive.getFiles(archiveData).getFiles().forEach(fsFile ->
							CacheFiles.write(index.getId(), archive.getArchiveId(), fsFile.getContents()));
					}
				}
				catch (IOException e)
				{
					e.printStackTrace();
				}
			});
		});
	}

And maybe detect an incomplete cache or wait until LOGIN_SCREEN as you have a full cache by that time.

Hello,

Game got extremely pixelated after install. Any fix on that? uninstalled the plugin and still have the issue.

GPU is off, nvidia settings to let application decide, 125 view distance. Not sure what is causing the crashing.

Just tried the plugin on my windows system, after waiting for about 5minutes after enabling the plugin(Still on the Downloading game cache, this may take a few minutes stage) The following exceptions occur:

2020-11-08 11:09:36 [Client] WARN  n.r.client.callback.ClientThread - Exception in invoke
java.lang.RuntimeException: 65544: WGL: Failed to set selected pixel format: The pixel format is invalid. 
	at renderer.plugin.BetterRendererPlugin.lambda$init$1(BetterRendererPlugin.java:154)
	at org.lwjgl.glfw.GLFWErrorCallbackI.callback(GLFWErrorCallbackI.java:36)
	at org.lwjgl.system.JNI.invokePPP(Native Method)
	at org.lwjgl.glfw.GLFWNativeWin32.glfwAttachWin32Window(GLFWNativeWin32.java:143)
	at renderer.plugin.JawtContextWindows.<init>(JawtContextWindows.java:23)
	at renderer.plugin.JawtContext.create(JawtContext.java:26)
	at renderer.plugin.BetterRendererPlugin.init(BetterRendererPlugin.java:157)
	at net.runelite.client.callback.ClientThread.lambda$invoke$0(ClientThread.java:48)
	at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:99)
	at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:191)
	at lv.qb(lv.java:38201)
	at client.ak(client.java)
	at ba.d(ba.java:361)
	at ba.run(ba.java:315)
	at java.base/java.lang.Thread.run(Unknown Source)
2020-11-08 11:09:36 [Client] ERROR client-patch - Game crash: null
java.lang.NullPointerException: null
	at renderer.plugin.BetterRendererPlugin.draw(BetterRendererPlugin.java:235)
	at client.rx(client.java:41655)
	at hz.ql(hz.java:985)
	at ef.cg(ef.java)
	at fu.xi(fu.java:10342)
	at bv.gs(bv.java:4616)
	at ax.ik(ax.java:9441)
	at kv.io(kv.java:9330)
	at client.zv(client.java:4263)
	at client.ak(client.java:1621)
	at ba.d(ba.java:361)
	at ba.run(ba.java:315)
	at java.base/java.lang.Thread.run(Unknown Source)

Running the pluginhub version 8b3e5be0d9e07074e08ffacf68273ca06b859194 on the release client.

If I leave the game on the 'Welcome to Runescape' (pre-login) screen with the plugin enabled, runelite will crash after a minute or two with the following uncaught exception

2020-11-14 03:12:19 [Thread-10] ERROR net.runelite.client.RuneLite - Uncaught exception:
java.lang.ThreadDeath: null
	at java.base/java.lang.Thread.stop(Unknown Source)
	at renderer.plugin.BetterRendererPlugin.lambda$shutDown$2(BetterRendererPlugin.java:205)
	at net.runelite.client.callback.ClientThread.lambda$invoke$0(ClientThread.java:48)
	at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:99)
	at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:191)
	at lv.qb(lv.java:38201)
	at client.ak(client.java)
	at ba.d(ba.java:361)
	at ba.run(ba.java:315)
	at java.base/java.lang.Thread.run(Unknown Source)

If you have both better renderer and gpu plugin enabled then disable gpu it looks all messed up.