ruilingk / pe Goto Github PK

This is similar to the delete and edit commands as mentioned previously.

deleteses, editses and clearses commands take y as yes and n as no, although it wasn't stated explictly in the user guide. So I am not sure if these are the intended behaviours of these commands.

Steps to reproduce:

1. Enter corresponding commands.
2. Enter y instead of yes.
3. Sessions get deleted, edited or cleared.
4. Repeat for n instead of no, in which this case it will not get deleted, edited or cleared.

Would be good if you can add the X to indicate end of lifeline and then indicate the limitation of PlantUML not having the dotted line to end where the X is.

Not sure if this was implemented in ATAS although it was given a priority of 3 stars.

Steps to reproduce:

1. Copy the following command highlighted in the picture below.
2. When pressing enter, there is an error because there is no spacing between the email and tag.

Actual:

Expected:

I think this is only a PDF conversion error.

I think it should be a constructor, missing brackets.

Although in the user guide it stated that the participate and presence commands toggles the participation and presence of a student, I am not sure if a tutor would want to toggle a student from participated to not participated and from present to not present.

Steps to reproduce for participate command:

1. Student 2 is marked as participated.
2. Enter participate 2-4.
3. This happens:
   

I was expecting that student 2 will still be marked as participated and 3 and 4 will be marked as participated too.

Steps to reproduce:

1. Enter deletestu 0.
2. Error message as shown:
   
3. Enter deletestu 10.
4. Error message as shown:
   

Since they are the same errors of invalid index, I think they should have the same error messages so that it is clear to the users.

I thought this should be placed towards the start of the user guide, or maybe have a hyperlink to this section for each of the commands that have confirmations.
Initially, I thought it was a bug so I kept making issues about it. :')

Not sure if User wants to delete student 1 would be a better representation?

This is similar to the deleting error message.

Steps to reproduce:

1. Enter editstu 0 n/welp
2. Error message as shown:
   
3. Enter editstu 10 n\welp
4. Error message as shown:
   

I think they are the same error.

This also applies to the sessons commands, participate and presence commands (those that has index concerned).

This is similar to the delete command confirmation.

Steps to reproduce:

1. Enter editstu 3 t/active.
2. Enter y.
   
3. Student is edited even though it should not be.
   

Same goes for n for no.

This goes for clearstu too, I shall not make a separate issue!

I thought it would be good to have an overall justification for the choices you made instead of just stating the pros and cons.

Steps to reproduce:

1. Have already Alvina Lee as name of student 1.
2. Enter editstu 1 n/Alvina Lee
3. No warning shown although edited name is the same as before:
   

If there is a very long tag as shown below:

The user would not be able to see the full tag.

Steps to reproduce:

1. Enter deletestu 9.
2. Confirmation as shown:
   
3. Enter n.
4. Student is not deleted.
   

Same goes for y for yes.

But in the UG, it did not state that short forms are allowed too:

This might cause unwanted deleting.

Although this was stated in the UG:

I still think that it can be quite logical if 2 sessions have the same names and different dates.

I think there should be an execute(...) here.

This is similar to issue #20.
I thought it would be good to have an overall justification for the choices you made instead of just stating the pros and cons.

Steps to reproduce:

1. Enter editstu 1 n/Alvin n/Another name as shown:
   
2. After confirming, it changes the name to Another name with no warning raised to the user:
   

It would be good to point out that the user is trying to edit the same field in the same command.

Since this section is about using short forms such as n for no, would it be better if the example given and screenshot given shows execution of n instead of no?

Not a major bug but I thought it would be good if once the note's length exceeds the size of the memo screen, it can be a new line.

Shown:

Not sure why only RngCommand has a X. Also I think the formatting for AtasParser is off.