cs-2.1-trees-sorting's People
cs-2.1-trees-sorting's Issues
Feedback on prefix trees
Great job on completing the prefix tree!
- Your complete and strings tests are failing. For your complete function, make sure you are finding all words in your tree that complete the given prefix, including the prefix itself if its terminal. Use print statements to debug your strings function. The error seems to indicate that it is returning None.
- You can further challenge yourself by working on time and space complexities for each prefix tree method. You would be expected to do this in interviews, and it would be good practice :)
Feedback on sorting algorithms
What was great:
- Good job on implementing your is_sorting function efficiently!
- Good job on successfully implementing your sorting algorithms!
Here's some feedback to improve:
- Try adding a couple more test cases! It may seem intimidating at first, but you've made it past the hard part. Implementation is way tougher than calling these functions and comparing inputs. In the work environment, writing tests will be required. Its a good habit to build :)
- Work on adding space and time complexities for your algorithms! This is a part of all interview questions in the hiring process!
Feedback on heaps, priority queues, and integer sorting algorithms
Great work on completing these challenges. Here's some feedback to improve your code:
- Your priority queue's front method is trying to access a size property that does not exist.
- For priority queues: In the front() method, your return’s get_min() function will return the tuple (priority, item) but you need to return just the item. Returning the item in the tuple (which is at index 1, not 0) for all of these functions will fix your priority queue implementation.
- Your heaping method should have 'self' as the first parameter since it is inside the class. Also, when you try to call heapify inside the method, you need to access it as a property of self -> self.heapify(). Same for your heap_sort, unless you want to pull these outside of the class (un-indent).
- Your counting sort fails tests. Try running
pytest sorting_test.py::IntegerSortTest
to see what errors you get and reach out if you need help debugging. This could likely be because your counting_sort is not in place, and mutating the original list before returning likeoriginal_list[:] = result
could fix the problem.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.