ruhsane / cs-2.1-trees-sorting Goto Github PK

Great job on completing the prefix tree!

• Your complete and strings tests are failing. For your complete function, make sure you are finding all words in your tree that complete the given prefix, including the prefix itself if its terminal. Use print statements to debug your strings function. The error seems to indicate that it is returning None.
• You can further challenge yourself by working on time and space complexities for each prefix tree method. You would be expected to do this in interviews, and it would be good practice :)

What was great:

• Good job on implementing your is_sorting function efficiently!
• Good job on successfully implementing your sorting algorithms!

Here's some feedback to improve:

• Try adding a couple more test cases! It may seem intimidating at first, but you've made it past the hard part. Implementation is way tougher than calling these functions and comparing inputs. In the work environment, writing tests will be required. Its a good habit to build :)
• Work on adding space and time complexities for your algorithms! This is a part of all interview questions in the hiring process!

Great work on completing these challenges. Here's some feedback to improve your code:

• Your priority queue's front method is trying to access a size property that does not exist.
• For priority queues: In the front() method, your return’s get_min() function will return the tuple (priority, item) but you need to return just the item. Returning the item in the tuple (which is at index 1, not 0) for all of these functions will fix your priority queue implementation.
• Your heaping method should have 'self' as the first parameter since it is inside the class. Also, when you try to call heapify inside the method, you need to access it as a property of self -> self.heapify(). Same for your heap_sort, unless you want to pull these outside of the class (un-indent).
• Your counting sort fails tests. Try running pytest sorting_test.py::IntegerSortTest to see what errors you get and reach out if you need help debugging. This could likely be because your counting_sort is not in place, and mutating the original list before returning like original_list[:] = result could fix the problem.