Use system clipboard content than tab url to gen code. about offline-qr-code HOT 5 OPEN

Good idea. Note that this would require a new permission for clipboard access likely, but that can (and should) be optional, so that's not a big deal.

HowTo

I imagine a setting with a checkbox:

• Use clipboard content when opening popup.

If you enable that, instead of using the tab URL it should override it (if required also possible with a message from the background script or so with the clipboard content.
If a permission is required, one can couple it in this extension with the PermissionRequest library (also used in other extensions, if one needs to get an example).

Important things:

• If the clipboard is empty, it should IMHO still fallback/use the website URL then as usual!
• If some text is selected and the option in the settings is enabled (as usual), this should take preference over the clipboard content IMHO.
  Reasoning: The thing is the clipboard is likely to contain outdated stuff, even passwords or so, which you have copied a quite long time ago, while a text selection on the website is much less permanent (i.e. goes away fast when you have to interact in some other way with the site) and selecting something may be a way more deliberate act than just copying sth. in another application even possibly or so.
• if a new permission is required please document it/why for the user.

That all said, I guess this is a good „good first issue“ thing if someone wants to really implement it. Note though, it may be not the easiest one, as one has to touch a few topics (settings, actual logic etc.) that are simplified due to the libs we use, but may still require some clever ideas or so.

from offline-qr-code.

New open source dev here, can I try this one?

from offline-qr-code.

Can I work on this?

from offline-qr-code.

Hi oh sorry for the delay, missed my notifications, yes you can both try. However, @Ravina-Deogadkar I just saw @frooia already did a PR in #286, so that is the base for implementation.

I thus will assign @frooia first, but if help is needed, of course I assume @Ravina-Deogadkar you can jump in and help here. Feel free to test or review the PR, BTW.

from offline-qr-code.

So @GrupaIMEX and @Ravina-Deogadkar if you want to take over/finish the PR #286 feel free to do so. There should just be some minor work to do.

from offline-qr-code.