rtykulsker / javabeanstalkclient Goto Github PK

 Job job = client.reserve(3600);

returns immediately with a null job when the watched tubes are empty. Is this expected?

using the 1.0.4 code in Downloads.

I can't reopen "Exception on ignore" (https://github.com/RTykulsker/JavaBeanstalkClient/issues/closed#issue/5) but it's not yet fixed.

package cohadar.beantest;

import java.util.Random;

import org.testng.annotations.Test;

import com.surftools.BeanstalkClient.Client;
import com.surftools.BeanstalkClient.Job;
import com.surftools.BeanstalkClientImpl.ClientImpl;

public class TestBeanstalkd {

/**
 * For some reason protocol cannot handle random binary data.
 * Throws com.surftools.BeanstalkClient.BeanstalkException: �L�bbs�4Y�N�Sk|� (garbage)
 * */
@Test
public void deathByRandom() throws Exception {
    Client client = new ClientImpl();

    for (int i = 0; i < 100; i++) {
        byte[] jobData = new byte[20000];

        new Random().nextBytes(jobData);  // <------<< comment this line and it works fine

        long jid = client.put(0, 0, 0, jobData);
        System.out.println("Inserted:" + jid);

        Job job = client.reserve(-1); // blocking wait
        jid = job.getJobId();
        System.out.println("Deleting:" + jid);
        client.delete(jid);
    }
}

}

I get

java.lang.NumberFormatException: null
at java.lang.Integer.parseInt(Integer.java:443)
at java.lang.Integer.parseInt(Integer.java:514)
at com.surftools.BeanstalkClientImpl.ClientImpl.ignore(ClientImpl.java:202)

when I .ignore("default");

Line 202 is in ignore()

        return Integer.parseInt(response.getReponse());

Apparently the response can be null.

I'm using beanstalk client 1.2.2 patched for the Linux performance problem, and beanstalk 1.4.3-1 on Ubuntu.

The pom.xml says junit 3.8.1, and "mvn install" won't build the tests. I put in 4.2, and it builds. (A test fails, but I'm looking into that.)

$ diff pom.xml.orig pom.xml
14c14
<           <version>3.8.1</version>

---
>           <version>4.2</version>

A small thing. One test I had to comment out:

    // underscores are now valid in tube names
    // try {
    //  client.useTube("foobar_");
    // } catch ( Exception e ) {
    //  fail(e.getMessage());
    // }

It would have been helpful to know _s are as of beanstalk 1.4.4: http://kr.github.com/beanstalkd/2010/03/09/1.4.4-release-notes.html. I'm running 1.4.3-1 because that's the latest Ubuntu 10.4 stable package.

Perhaps change the comment to

// underscores are valid in tube names >= beanstalk 1.4.4.

The latest version on Maven Central is 1.4.6

version 1.7.0

Steps to reproduce:

1. Start beanstalkd

2. Client client = new ClientImpl("localhost", 11300);
    client.reserve(null);
   

3. Stop beanstalkd

Inside ProtocolHandler.readInputStream in while loop code doesn't handle -1 returned from is.read(); Might be something like this:

        while (true) {
            byte b = (byte) is.read();

            if (b == -1) {
                throw new IOException("The end of InputStream is reached");
            }
            baos.write(b);
            if (b == '\n' && lastByteWasReturnByte) {
                break;
            }
            lastByteWasReturnByte = (b == '\r');
        }

java.lang.OutOfMemoryError: Java heap space
at java.util.Arrays.copyOf(Arrays.java:2786)
at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:71)
at com.surftools.BeanstalkClientImpl.ProtocolHandler.readInputStream(ProtocolHandler.java:130)
at com.surftools.BeanstalkClientImpl.ProtocolHandler.processRequest(ProtocolHandler.java:72)
at com.surftools.BeanstalkClientImpl.ClientImpl.reserve(ClientImpl.java:100)

The puts look fine (0-1ms). However, I bet Maven or Junit thinks anything ending in "Test" needs a unit test, so it's saying:

<<< ERROR!
java.lang.Exception: No runnable methods
at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:34)
...

I renamed to TimedPutTester, and it skips that file.