rroller / netgear Goto Github PK

All sensors created by the integration gets device_class "safety", which to my understanding is used for binary sensors and not regular sensors. This removes the unit_of_measurement value for the sensors, and makes it hard to use the information from the sensor in home assistant. Removing the device_class from the sensors would be better.

My hardware is 2 WAC510.

Describe the bug

On startup there are 4 errors with stack trace as below, 1 per device,
It seems that all components are working correctly.

Debug log

today at 4:36:30 PM 2021-08-22 16:36:30 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry ************ for binary_sensor
today at 4:36:30 PM Traceback (most recent call last):
today at 4:36:30 PM   File "/usr/src/homeassistant/homeassistant/config_entries.py", line 293, in async_setup
today at 4:36:30 PM     result = await component.async_setup_entry(hass, self)  # type: ignore
today at 4:36:30 PM   File "/usr/src/homeassistant/homeassistant/components/binary_sensor/__init__.py", line 144, in async_setup_entry
today at 4:36:30 PM     return await component.async_setup_entry(entry)
today at 4:36:30 PM   File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 149, in async_setup_entry
today at 4:36:30 PM     platform = await async_prepare_setup_platform(
today at 4:36:30 PM   File "/usr/src/homeassistant/homeassistant/setup.py", line 329, in async_prepare_setup_platform
today at 4:36:30 PM     platform = integration.get_platform(domain)
today at 4:36:30 PM   File "/usr/src/homeassistant/homeassistant/loader.py", line 498, in get_platform
today at 4:36:30 PM     cache[full_name] = self._import_platform(platform_name)
today at 4:36:30 PM   File "/usr/src/homeassistant/homeassistant/loader.py", line 503, in _import_platform
today at 4:36:30 PM     return importlib.import_module(f"{self.pkg_path}.{platform_name}")
today at 4:36:30 PM   File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
today at 4:36:30 PM     return _bootstrap._gcd_import(name[level:], package, level)
today at 4:36:30 PM   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
today at 4:36:30 PM   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
today at 4:36:30 PM   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
today at 4:36:30 PM   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
today at 4:36:30 PM   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
today at 4:36:30 PM   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
today at 4:36:30 PM   File "/config/custom_components/netgear_wax/binary_sensor.py", line 26, in <module>
today at 4:36:30 PM     class NetgearBinarySensor(NetgearBaseEntity, BinarySensorEntity):
today at 4:36:30 PM   File "/config/custom_components/netgear_wax/binary_sensor.py", line 29, in NetgearBinarySensor
today at 4:36:30 PM     def __init__(self, coordinator: NetgearDataUpdateCoordinator, config_entry, sensor_type: str):
today at 4:36:30 PM NameError: name 'NetgearDataUpdateCoordinator' is not defined

I'm using the component for 4 devices I have,
After deep investigation of an increased number of DNS calls from the devices I found out that the component is fetching data of FwUpdate and internetConnectivityStatus which samples Google cloud,
Since the update mechism of the component is running every 30 seconds, it generates in best case scenario 5 DNS calls every 30 seconds - 14k requests a day per device!

To solve it, I suggest to perform internetConnectivityStatus call only once every few minutes and FwUpdate can be performed once a day.

It can also be based on configuration with default values.

thanks

Upon reloading the component throws a missing argument exception

Debug log

today at 10:28:29 AM 2021-08-23 10:28:29 ERROR (MainThread) [homeassistant.config_entries] Error unloading entry **-******-** for netgear_wax
today at 10:28:29 AM Traceback (most recent call last):
today at 10:28:29 AM   File "/usr/src/homeassistant/homeassistant/config_entries.py", line 432, in async_unload
today at 10:28:29 AM     result = await component.async_unload_entry(hass, self)  # type: ignore
today at 10:28:29 AM   File "/config/custom_components/netgear_wax/__init__.py", line 166, in async_unload_entry
today at 10:28:29 AM     await coordinator.async_stop()
today at 10:28:29 AM TypeError: async_stop() missing 1 required positional argument: 'event'

Not sure whether this is down to the altest updates to Home Assistant or a firmware update on the devices as it happened at similar times but I now get the following error for both my WAX devices

WARNING (MainThread) [homeassistant.config_entries] Config entry 'Wax610' for netgear_wax integration not ready yet; Retrying in background
WARNING (MainThread) [homeassistant.config_entries] Config entry 'Wax620' for netgear_wax integration not ready yet; Retrying in background

Anyone else seeing this, repeated reloads and restarts are not resolving it.

I think this may have to do with the UPnP of the WAC104 not being compatible.
I have no problem with the R7800 Router. Not a big thing but would be nice to add
the WAC104

Logger: pynetgear.router
Source: components/netgear/router.py:53
First occurred: 1:14:30 PM (6 occurrences)
Last logged: 1:45:01 PM

login using all known port-ssl combinations failed.

Support for wlan2 for WAX630.

These minor changes are suggested in order to support wlan2 on the WAX630 (the lines to change should be pretty obvious, near each occurrence of wlan1).

sensor.py:

for lan in ["wlan0", "wlan1", "wlan2"]:

for lan in ["lan", "wlan0", "wlan1", "wlan2"]:

client_wax.py:

for lan in ["lan", "wlan0", "wlan1", "wlan2"]:

const.py:

           },
           "wlan2": {
               "traffic": "",
               "channelUtil": "",

Those seem to be enough to properly support my WAX630.

Is your feature request related to a problem? Please describe.
I have three WAX610 devices in my network, and would like to manage all of them.

Describe the solution you'd like
It would be great if I could add more devices to the integration.

Describe alternatives you've considered
Could not think of any

Version of the custom_component

I couldn't find a version number in const.py

Describe the bug

Updated WAX610 firmware to V10.5.0.16 then the HA netgear integration could not connect to WAX610. I tried to delete one AP and add it again without success.

Debug log

2023-08-22 10:21:22.953 DEBUG (MainThread) [custom_components.netgear_wax] Creating client with username admin
2023-08-22 10:21:22.953 DEBUG (MainThread) [custom_components.netgear_wax] Checking for firmware updates
2023-08-22 10:21:23.221 DEBUG (MainThread) [custom_components.netgear_wax] Creating client with username admin
2023-08-22 10:21:23.221 DEBUG (MainThread) [custom_components.netgear_wax] Checking for firmware updates
2023-08-22 10:21:23.638 ERROR (Thread-109 (init_websocket)) [websocket] [Errno 113] Host is unreachable - goodbye
2023-08-22 10:21:24.513 DEBUG (MainThread) [custom_components.netgear_wax] Logging in with username admin
2023-08-22 10:21:24.756 DEBUG (MainThread) [custom_components.netgear_wax] Logging in with username admin
2023-08-22 10:21:25.604 DEBUG (MainThread) [custom_components.netgear_wax] login security token response={ "status": 401 }
2023-08-22 10:21:25.604 DEBUG (MainThread) [custom_components.netgear_wax] Failed to read current state
Traceback (most recent call last):
File "/config/custom_components/netgear_wax/init.py", line 118, in _async_update_data
self._state = await self.client.async_get_state(check_firmware)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/netgear_wax/client_wax.py", line 93, in async_get_state
result = await self.async_post(request_data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/netgear_wax/client_wax.py", line 199, in async_post
await self.async_login()
File "/config/custom_components/netgear_wax/client_wax.py", line 57, in async_login
raise Exception("Could not get security token: " + text)
Exception: Could not get security token: { "status": 401 }
2023-08-22 10:21:25.634 DEBUG (MainThread) [custom_components.netgear_wax] Finished fetching netgear_wax data in 2.681 seconds (success: False)
2023-08-22 10:21:25.899 DEBUG (MainThread) [custom_components.netgear_wax] login security token response={ "status": 401 }
2023-08-22 10:21:25.899 DEBUG (MainThread) [custom_components.netgear_wax] Failed to read current state
Traceback (most recent call last):
File "/config/custom_components/netgear_wax/init.py", line 118, in _async_update_data
self._state = await self.client.async_get_state(check_firmware)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/netgear_wax/client_wax.py", line 93, in async_get_state
result = await self.async_post(request_data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/netgear_wax/client_wax.py", line 199, in async_post
await self.async_login()
File "/config/custom_components/netgear_wax/client_wax.py", line 57, in async_login
raise Exception("Could not get security token: " + text)
Exception: Could not get security token: { "status": 401 }
2023-08-22 10:21:25.900 DEBUG (MainThread) [custom_components.netgear_wax] Finished fetching netgear_wax data in 2.679 seconds (success: False)

Is your feature request related to a problem? Please describe.
i have a wax 202 netgear. I tried to add it whith your embed but it tells me "Username, Password, or Address is wrong." I checked the passeword and ip address is good

Describe the solution you'd like
can you add the wax 202 please

Version of the custom_component

0.1.4

Device information

Netgear WAX615
Firmware version: V10.5.0.14

Configuration

logger:
  default: info
  logs:
    custom_components.netgear_wax: debug

Nothing else related to this component is included in configuration.yaml.

Describe the bug

Upon trying to add the integration, the following error is displayed:

Username, Password, or Address is wrong.

I have triple checked that fields are correct.

Debug log

Pasting the relevant log lines found in home-assistant.log after enabling debug logs for custom_components.netgear_wax:

2023-08-24 16:43:54.135 DEBUG (MainThread) [custom_components.netgear_wax] Creating client with username admin
2023-08-24 16:43:55.092 DEBUG (MainThread) [custom_components.netgear_wax] Logging in with username admin
2023-08-24 16:43:56.590 DEBUG (MainThread) [custom_components.netgear_wax] login security token response={ "status": 401 }
2023-08-24 16:43:56.591 ERROR (MainThread) [custom_components.netgear_wax] Failed: Could not get security token: { "status": 401 }
Traceback (most recent call last):
  File "/config/custom_components/netgear_wax/config_flow.py", line 87, in _test_credentials
    state = await client.async_get_state()
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/netgear_wax/client_wax.py", line 93, in async_get_state
    result = await self.async_post(request_data)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/netgear_wax/client_wax.py", line 199, in async_post
    await self.async_login()
  File "/config/custom_components/netgear_wax/client_wax.py", line 57, in async_login
    raise Exception("Could not get security token: " + text)
Exception: Could not get security token: { "status": 401 }

Looking forward to getting some feedback. Thanks!

Hi,

Thanks for building that component, planned to do that a long ago but didn't get to it,
I installed and configued it for my 4 WAC-510 units, works great,
Can you please update:

• README - supported models
• Translation of setup - description is currently indicating Only WAX models supported for now
• HA Forums

thanks

I need some help.
After installation I go to "Configuration -> Integration -> Add Integration -> Netgear WAX".

I complete the forms with my informations :

• Username : admin
• Password : mypassword which work on my admin portal (https://192.168.1.32/cgi-bin/luci)
• Address : 192.168.1.32
• Port : 443

But I get the error message : "Username, Password, or Address is wrong."
The only info which can be wrong I think it's the port but how I can I check the port ? In the admin portal I don't find the info

Thanks a lot !

Version of the custom_component

Configuration

Add your logs here.

Describe the bug

When this integration is enabled procssor usage goes from ~5% to over ~25%. Turn off the integration and the processor usage goes back down.

Debug log

Add your logs here.