Giter Club home page Giter Club logo

Comments (6)

hughsie avatar hughsie commented on August 16, 2024

Why are we using qsort_r() and not just qsort()? Given we now depend on Glib, it would also be interesting if any of the sorting callbacks can be used with qsort().

from libdnf.

Conan-Kudo avatar Conan-Kudo commented on August 16, 2024

@hughsie I dunno. If you can fix it without me having to use libsolv's qsort_r implementation, I'm cool with that.

from libdnf.

mlschroe avatar mlschroe commented on August 16, 2024

(The easiest fix is probably to switch to solv_sort in hawkey)

from libdnf.

Conan-Kudo avatar Conan-Kudo commented on August 16, 2024

@mlschroe So your solv_sort() function is exported and available for consumers of libsolv to use? If that's the case, then that might be the appropriate solution, as it would also ensure that libsolv and hawkey/libhif are always using the same qsort_r implementation.

What do you think, @hughsie?

from libdnf.

hughsie avatar hughsie commented on August 16, 2024

Makes sense to me.

from libdnf.

Conan-Kudo avatar Conan-Kudo commented on August 16, 2024

@hughsie If you could go ahead and switch hif/hawkey to use solv_sort() from libsolv in place of qsort_r(), that would solve the problem.

from libdnf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.