set up rpm log callback to acquire errors from more places about libdnf HOT 9 CLOSED

We need to choose whether to copy rpmlog data into https://developer.gnome.org/glib/stable/glib-Error-Reporting.html or just have a wrapper API in HifContext for callers to set up a callback.

from libdnf.

See this code:

    rc = rpmtsRun(priv->ts, NULL, problems_filter);
    if (rc < 0) {
        ret = FALSE;
        g_set_error(error,
                    HIF_ERROR,
                    HIF_ERROR_INTERNAL_ERROR,
                    "Error running transaction: %s", rc, priv->error_log);
        goto out;
    }

from libdnf.

I'm also getting bitten by the rather opaque -1 error.

from libdnf.

I think using a GError is the only sane way to handle this.

from libdnf.

In response to my opaque -1 error (in rpm-ostree), I tried calling rpmlogSetCallback during hif_context_new (was just looking at something that would be called early on) to a callback that prints everything. I also had to catch an attempt by hif_rpmts_find_package to set the callback back to NULL.

End result was that my logging callback never got called, so I think I must be doing something wrong.

from libdnf.

Re: GError...the problem I see with that is that there can potentially be a lot of output, right? Or just multiple unrelated lines. I'd lean a bit towards just having a thin wrapper for rpmSetLogCallback and promising not to call it ourselves. But it's not a strong opinion. Perhaps we can do both even, use GError by default but allow callers to get the logs directly.

from libdnf.

I realized my issue was because I was missing rpmlogSetMask or rpmSetVerbosity. Now it's plenty chatty 😄

from libdnf.

Is the issue still valid?

from libdnf.

I am closing for an inactivity.

from libdnf.