rpgillespie6 / posix-regex-cpp Goto Github PK

1. If group passed as parameter to group(), start() or end() equals pgroups.size(), it leads to segmentation fault, because the vector pgroups cannot access that index.
2. On compiling POSIXRegex.cpp with g++ -Wall POSIXRegex.cpp, some warnings are shown with message comparison between signed and unsigned integer expressions. These warnings are in group(), start() and end() functions.

Suppose I have a regular expression "([A-Z]+)|([0-9]+)". So I want to match either alphabets or numeric characters. I compile this regex and give it a input string to match, say "HELLO".

When I try to see the matched groups, group(0) gives "HELLO", group(1) gives "HELLO", group(2) fails with segmentation fault with message terminate called after throwing an instance of 'std::out_of_range'. what(): basic_string::substr.

Instead of directly returning substr, first the start and end index for group must be checked and if they are equal to -1, empty string should be returned.