Giter Club home page Giter Club logo

Comments (21)

HinTak avatar HinTak commented on June 20, 2024

Try C:\\Windows\\Fonts\\حُرّ عادي.ttf (double backslash) or "C:/Windows/Fonts/حُرّ عادي.ttf". This is likely a Windows IO anomaly.

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

I try the two method you have suggest. Both of them give me the same exception.

freetype.Face("C:\\Windows\\Fonts\\حُرّ عادي.ttf")
freetype.Face("C:/Windows/Fonts/حُرّ عادي.ttf")

from freetype-py.

rougier avatar rougier commented on June 20, 2024

Can you print here what is Path(r"C:\Windows\Fonts\حُرّ عادي.ttf")?

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

It print me this (so the exact same thing that I provide): C:\Windows\Fonts\حُرّ عادي.ttf

from freetype-py.

rougier avatar rougier commented on June 20, 2024

Is is a PosixPath ?

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

No, simply a path.

It will instanciate a windows path since I am on windows: https://docs.python.org/3/library/pathlib.html

from freetype-py.

HinTak avatar HinTak commented on June 20, 2024

AFAIK it needs to be something acceptable to windows' c runtime's fopen().

Python 3 is unicode internally and needs some encoding on all platforms. Unix's takes utf8, while some windows internal bits are utf16. You might be able to experiment by playing with python ctypes on Windows directly. I am afraid this is one area where playing with wine does not help, and wine differs slightly in behavior compared to windows. Ie running windows python on wine is no help.

from freetype-py.

rougier avatar rougier commented on June 20, 2024

@HinTak We could use pathlib internally and we would be on the safe side, no?

from freetype-py.

HinTak avatar HinTak commented on June 20, 2024

@rougier yes, apparently it is included in python standard library since 3.4 (and we had a separate frozen-ish 2.x branch). If anybody cares enough about older 3.x, they should do their own thing and/or submit a pull.

That said, we really want to know why it doesn't work on Windows with non-ascii paths. The "/" vs "" (and needing to double "\" or switch to "/") is relatively well known. Win32 IO have ascii vs unicode IO routines, but I don't think freetype uses those.

Thinking about it, @moi15moi , where did you get your libfreetype.dll? I am wondering if msvc compiled ones uses the win32 routines. I am quite sure mingw built ones don't.

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

Thinking about it, @moi15moi , where did you get your libfreetype.dll? I am wondering if msvc compiled ones uses the win32 routines. I am quite sure mingw built ones don't.

I don't know what you are talking about. I just install freetype-py like this: pip install freetype-py

from freetype-py.

HinTak avatar HinTak commented on June 20, 2024

@moi15moi argh, sorry somebody else among the team did the bundled binaries. According to https://pypi.org/project/freetype-py/#description , it is probably msvc (=visual studio) + cmake -built.

from freetype-py.

rougier avatar rougier commented on June 20, 2024

I agree it would be good to know why it fails. See also https://jod.al/2019/12/10/pathlib-and-paths-with-arbitrary-bytes/

from freetype-py.

HinTak avatar HinTak commented on June 20, 2024

I was just reminded of a somewhat similar issue in a different project I work on:
Robmaister/SharpFont#89
File names go through two translation processes, one as it crosses the non-C / C boundary (in both cases, the non-C sides are widows-based and uses UTF16). Then between freetype and the file-system. There workaround there was to read the file in full in memory on the non-C side, and passes the whole block of memory to freetype. (We never "solved" it, just found a workaround and moved on...)

The two questions are mainly what bytes as a file name FreeType receives, and can one open a file with those bytes via fopen.

from freetype-py.

rougier avatar rougier commented on June 20, 2024

Can't we use the pathlib library to solve the translation problem for us then?

from freetype-py.

cd-86 avatar cd-86 commented on June 20, 2024

I encountered the same problem, and it was solved by changing the encoding of line 162 of freetype/init.py to ansi

def _encode_filename(filename):
    # encoded = filename.encode(sys.getfilesystemencoding())
    encoded = filename.encode('ansi')
    if "?" not in filename and b"?" in encoded:
        # A bug, decoding mbcs always ignore exception, still isn't fixed in Python 2,
        # view http://bugs.python.org/issue850997 for detail
        raise UnicodeError()
    return encoded

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

This is not a good idea.

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

@rougier Have you found any alternative?

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

I just found this issue: https://gitlab.freedesktop.org/freetype/freetype/-/issues/1098
This may help you

from freetype-py.

HinTak avatar HinTak commented on June 20, 2024

No, you did not notice the "won't fix" label on the issue you referenced. :-).

from freetype-py.

moi15moi avatar moi15moi commented on June 20, 2024

Exactly. Then, when the font filename contain an non ascii char and the platform is windows, we could simply create a memory font.

from freetype-py.

HinTak avatar HinTak commented on June 20, 2024

Not sure what you are asking for. It is the same as what you did, freetype.Face(Path(r"C:\Windows\Fonts\حُرّ عادي.ttf").open("rb")), creating a memory font. This is pretty much how the sharpfont solution works too, just read it via the non-C way, then passes the block of memory to the c-side to freetype.

from freetype-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.