Giter Club home page Giter Club logo

Comments (9)

pshihn avatar pshihn commented on May 10, 2024 2

Path2D is only used when filling with hachure styles in paths. Not in issue for other shape constructs.
I want to move away from Path2D anyway because it will solve some other minor issues as well. Working on some good algorithms that may work as an alternative

from rough.

AddictArts avatar AddictArts commented on May 10, 2024 2

I used the babel-polyfill to fix the missing "async" after running into it. Simple add to my project build.

from rough.

AddictArts avatar AddictArts commented on May 10, 2024

It can be fixed with mixed results, for example rc.path did not work, no Path2D support?

// I was able to add or install dev dependencies babel-cli, ... listed below and then the babel-polyfill
 "devDependencies":
    "babel-cli": "^6.26.0",
    "babel-preset-es2015": "^6.24.1",
    "babel-preset-es2017": "^6.24.1",
    "uglify-js": "^3.3.16"

  "dependencies":
    "babel-polyfill": "^6.26.0"

And you need a suitable babelrc

{
  "presets": [ "es2017", "es2015" ]
}

And then a way to run babel and uglify, for example I added to package.json

    "babel-es5": "babel dist/rough.js -o dist/rough.es5.js",
    "minify-u": "uglifyjs dist/rough.es5.js -o dist/rough.min.js",

from rough.

OSUblake avatar OSUblake commented on May 10, 2024

It can be fixed with mixed results, for example rc.path did not work, no Path2D support?

IE11 does not support Path2D. Edge does, but there is an issue with SVG path data.
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8438884/

from rough.

pshihn avatar pshihn commented on May 10, 2024

The build now includes an ES5 version.

from rough.

zoosky avatar zoosky commented on May 10, 2024

Cool

from rough.

Nalca avatar Nalca commented on May 10, 2024

I tried the ES5 version and it does not work on IE11.
Not when the keyword async is present. It's a ES2017 keyword.

from rough.

pshihn avatar pshihn commented on May 10, 2024

@Nalca you're right
I need to run this through babel to fix those. May need a Promise polyfill as well.
PRs welcome. Not sure when I'll get a chance.

from rough.

pshihn avatar pshihn commented on May 10, 2024

Removed Path2D dependency.

from rough.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.