Comments (9)
Path2D is only used when filling with hachure styles in paths. Not in issue for other shape constructs.
I want to move away from Path2D anyway because it will solve some other minor issues as well. Working on some good algorithms that may work as an alternative
from rough.
I used the babel-polyfill to fix the missing "async" after running into it. Simple add to my project build.
from rough.
It can be fixed with mixed results, for example rc.path did not work, no Path2D support?
// I was able to add or install dev dependencies babel-cli, ... listed below and then the babel-polyfill
"devDependencies":
"babel-cli": "^6.26.0",
"babel-preset-es2015": "^6.24.1",
"babel-preset-es2017": "^6.24.1",
"uglify-js": "^3.3.16"
"dependencies":
"babel-polyfill": "^6.26.0"
And you need a suitable babelrc
{
"presets": [ "es2017", "es2015" ]
}
And then a way to run babel and uglify, for example I added to package.json
"babel-es5": "babel dist/rough.js -o dist/rough.es5.js",
"minify-u": "uglifyjs dist/rough.es5.js -o dist/rough.min.js",
from rough.
It can be fixed with mixed results, for example rc.path did not work, no Path2D support?
IE11 does not support Path2D. Edge does, but there is an issue with SVG path data.
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8438884/
from rough.
The build now includes an ES5 version.
from rough.
Cool
from rough.
I tried the ES5 version and it does not work on IE11.
Not when the keyword async is present. It's a ES2017 keyword.
from rough.
@Nalca you're right
I need to run this through babel to fix those. May need a Promise polyfill as well.
PRs welcome. Not sure when I'll get a chance.
from rough.
Removed Path2D dependency.
from rough.
Related Issues (20)
- ellipse with 0 roughness is still irregular HOT 1
- Use in Nextjs HOT 5
- Solid fill goes out of bounds for arcs larger than 180 degrees HOT 4
- Disable floating points HOT 6
- "Dots" fill looks weird when units are scaled up HOT 6
- Is there a way to use other attributes of the the SVG rectangle, such as "rx?" HOT 4
- 0-roughness ellipse not closed in specific cases HOT 3
- Ellipse not completely filled HOT 1
- Feature Request HOT 3
- mermaid language to rough HOT 2
- support inside/outside strokes
- Scanline hachutre lines drawing outside polygon for certain angles
- Roughjs not running on Typescript files
- Compatibility roughs.js - gsap for animation HOT 1
- Interoperability with Pencil HOT 2
- Ability to pass fill rule through options HOT 2
- Dot filling is not constant with fixed seed
- Is this project abandoned?
- Any examples of this used in React Typescript? HOT 1
- Hachure fill is randomly missing for certain fractional hachureGap values HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rough.