rotundasoftware / cartero-node-hook Goto Github PK

getAssetUrl throws an error

Managed to fix the issue by changing line 89:

    return this.metaData.packageMap[ srcDir ] ? '/' + this.metaData.packageMap[ srcDir ] : null; 

with:

    return _this.metaData.packageMap[ srcDir ] ? '/' + _this.metaData.packageMap[ srcDir ] : null; 

In my use case I have a Handlebars helper that output the url of the bundles using this hook. The problem that I'm facing is since the hook works in a async way, the first time it is executed the url is not returned.

I've created a sync version of the hook: https://github.com/ferlores/cartero-node-hook-sync

I would like to hear your thoughts about this and understand if I'm missing something. Maybe there's a reason on why you did it in this way from the beginning

Thanks!
F

I noticed while upgrading, the definition wasnt correct in the docs.