roshnet / blogstate-api Goto Github PK

Description

On all endpoints that return a date (for example, on returning posts), a small script can be inserted that converts the current date format 2019-11-03 to a more convenient format, say October 30, 2019.

There is a possible use case in the main application of using a library like MomentJS to add more convenient formats.

Currently, in cases where the query is unsuccessful, the response still has a status code of default 200.

There needs to be a suitable HTTP status code allotted to the response, to better handle and debug the API.

Description

As of now, for POST /login and POST /signup, the request body needs to have a specific structure.
If that structure of request body is different from what is assumed in handling it, an exception is caused, which can cause entire server to halt, and other undesired effects.

Fix

This can be prevented by validating request body structure, and returning appropriate response if the structure is corrupt.

Error, database must be initialized before opening a connection

Description

When subsequent requests are sent, only the first call executes.
This gives a peewee.OperationalError: Connection already opened. error.

Possible cause

Peewee is configured to make a call to the database on each request, as falcon.API()'s middleware.
This seems to override the already opened connection that was opened on the first API call.

Possible solution

Since it's the middleware that performs the database call, a check needs to be put in the middleware on whether the current connection state is opened or closed.