ropenspain / cartociudad Goto Github PK

From R CMD check --as-cran:

* checking examples ... NOTE
Examples with CPU or elapsed time > 5s
                             user system elapsed
cartociudad_reverse_geocode 0.032  0.002   26.56

https://github.com/orgs/rOpenSpain/projects

Dear developers,

I have created a fork including the deploy of your package on your gh-pages branch using the rostemplate (see Slack channel and https://ropenspain.github.io/rostemplate/). See a live preview of your pkgdown site here:
https://dieghernan.github.io/caRtociudad/

An additional GitHub Action check-standard.yaml has been included. That action would check your package (AS CRAN) on several platforms on every push, pull request and every first day of the month at 8:00 AM. The goal is to provide CI on your package.

Note that this action could be redudant with your _travis current configuration, but you can still keep both without interferences between them.

Actions on your package:

• Check locally and rebuild documentation (upgrade Roxygen version)

• Implementation of github-actions and related .gitgnore and .Rbuildignore

• Your cron check action is set to 8:00 AM. In previous runs some checks were not succesful due to errors on API endpoint (not the package itself). Moved to 8:00AM to avoid working hours.

Next steps

You should receive a Pull Request with these modifications.

After your review and in case you consider merging, consider to deploy Github Pages on your settings (gh-pages branch).

Once it is done, I would appreciate if you move this issue to the Deployed tab on the Project panel (see also Projects tab on this website)

LOG

• @dieghernan reviewing
• @cjgb @@koldLight owners

Fork: https://github.com/dieghernan/caRtociudad/
Live preview: https://dieghernan.github.io/caRtociudad/

TODO: Open issue and pull request. Final deploy up to the owners of the repo

Revisar las referencias en la documentación a funciones. Hay funciones que cambiaron de nombre por unificar, y hay ejemplos en el README.md y documentación que usan el nombre antiguo.

Caso detectado: get_cartociudadmap

This issue will list all the observed request that the cartociudad API is returning wrong geocoding results.

• "cuesta del observatorio 4, 18080 granada", should return 37.190205, -3.5947971. Now is returning 37.18018, -3.5898. Request here

If you observed this behaviour with another address, please add a new comment to this issue with:

• The exact text in your request
• The expected result (e.g. when querying the same text to google maps)

cartociudad has improved some of their services, by adding new endpoints for doing:

• geocoding
• reverse geocofing

More details here

Their API reference doc will be update soon

Hello,
This library is really helpfull, it would be even more if you could just retrieve the centroide based just on the zip code. ¿Is there any plannification for adding such new features?

Thanks