httr usage about stplanr HOT 6 CLOSED

Good advice. I have made your suggested changes to the functions that currently use the httr package.

This is probably also a good opportunity to standardise the use of the httr package for retrieving remote data. Some other functions in the package currently use the RCurl package directly.

from stplanr.

Thanks Scott for the advice - this was my bad as I didn't know about correct httr usage when I set that up. I think we should remove use of the RCurl package - you up for taking a look that Richard, maybe as part of #102 ? I think some its used in code you wrote.

Just to clarify, after 082eca9 what else do we need to do to close this?

Really appreciate that code example btw - will use that style in future functions that call APIs - was wondering what best practice was and now I know which is really, really useful.

from stplanr.

no bad at all, and dont consider my suggestions the "correct way", but rather what I've found to be the best usage pattern thus far

I'll have a look at the PR

from stplanr.

I'll go through the rest of the functions and replace any RCurl functions with httr. From habit I tend to use RCurl directly but certainly using httr is probably better practice (and that way we're consistent).

from stplanr.

@sckott I've set pat = NULL as the default here: 05018d4

Any other suggestions welcome.

from stplanr.

nothing else I can see at this point, nice work !

from stplanr.