Comments (3)
Robinlovelace
commented on June 23, 2024
Another 10x+ speed-up, FYI @mem48, @JosiahParry, @palelimbot, @kadyb and anyone else interested in perf. What lwgeom slowness doing and worth reporting upstream?
> l <- flowlines_sf[1:5, ]
> bearings_sf_1_9 <- line_bearing(l)
> bearings_sf_1_9 # lines of 0 length have NaN bearing
[1] -92.04942 -102.44566 -143.83660 -173.33154 170.51696
> line_bearing(l, bidirectional = TRUE)
[1] 87.950582 77.554344 36.163396 6.668455 -9.483044
> # benchmark:
> profvis::profvis(line_bearing(l))
> bm = bench::mark(line_bearing(l))
> l <- flowlines_sf[1:5, ]
> bearings_sf_1_9 <- line_bearing(l)
> bearings_sf_1_9 # lines of 0 length have NaN bearing
[1] -92.04942 -102.44566 -143.83660 -173.33154 170.51696
> line_bearing(l, bidirectional = TRUE)
[1] 87.950582 77.554344 36.163396 6.668455 -9.483044
> # benchmark:
> # profvis::profvis(line_bearing(l))
> bm = bench::mark(line_bearing(l))
> bm2 = bench::mark(geosphere = {
+ odc = od::od_coordinates(l)
+ geosphere::bearing(
+ p1 = odc[, 1:2],
+ p2 = odc[, 3:4]
+ )
+ })
> bm$`itr/sec`
[1] 58.62699
> bm2$`itr/sec`
[1] 3095.411
> bm2$`itr/sec` / bm$`itr/sec`
[1] 52.79839
from stplanr.
Robinlovelace
commented on June 23, 2024
New implementation, same results:
> bearings_sf_1_9 # lines of 0 length have NaN bearing
[1] -92.04942 -102.44566 -143.83660 -173.33154 170.51696
from stplanr.
Robinlovelace
commented on June 23, 2024
> line_bearing(l, bidirectional = TRUE)
[1] 87.950582 77.554344 36.163396 6.668455 -9.483044
from stplanr.
Related Issues (20)
- Comparing the results between angle_diff with calculate_angle/get_vector HOT 1
- Error message in bind_sf
- CRAN issues
- bug in the rnet_merge function when defining the funs HOT 3
- Use different buffer options in `rnet_merge()`
- Convert large GeoJSON file to PMTiles HOT 1
- bug in geo_buffer HOT 7
- Possible speed enhancement to `mats2line()` HOT 3
- Invalid LineStrings in routes_fast_sf HOT 1
- Use `od::odc_to_sfc()` do the legwork in `mats2line()` HOT 3
- Bug in `line_segment()` when using certain values on projected data with `rsgeo` implementation HOT 8
- `rnet_merge()` fails when inputs are projected HOT 4
- Argument of segment_length in line_segment fun causes issue HOT 14
- Tried creating a route from desirelines using osrm function HOT 9
- rnet merge function can't not handle attributes containing strings HOT 1
- Add links to more papers in DESCRIPTION
- Re-add n_segments argument to line_segment() HOT 1
- `line_segment()` fails when n_segments has multiple values HOT 1
- od2line() throws an error if only one origin-destination relation is selected HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stplanr.