is it possible to do tank definition without mixin? about fluidized-tanks HOT 9 OPEN

With some refactor and rethink, yes, maybe. I'm welcoming PRs since this is a low priority project.

from fluidized-tanks.

This causes a pretty serious conflict, with a good chunk of apotheosis broken if used

from fluidized-tanks.

Got a crash report/log when this happens?

from fluidized-tanks.

latest.log

from fluidized-tanks.

no clue what to look for tbh

from fluidized-tanks.

@Frefreak will you be PRing? If not then I can only get around to fixing it around September time.

from fluidized-tanks.

I'd like to give this a shot at some point but not sure when exactly. Recently I've been a bit addicted to baldur's gate 3 though.
I will leave a comment here when I start doing this.

from fluidized-tanks.

Totally understandable ^^

from fluidized-tanks.

After some experimenting it seems if I enable this line:

and remove the mixin, the tank definition can work but the recipes for those tanks will be missing. In order for those recipes to present it appears the TankDefinitionManager listener needs to be before the TagManager (the first listener returned by the origin minecraft logic). I find no obvious way to do this other than the current mixin way :(

Another route I tried is to also modify the recipe json directly, replacing the TankDefinitionId tag with TankDefinition (Capacity, Colour, Id). This seems to work fine but introduces some data redundancy with the data json files.

Are you against the json way or do you have something better in mind?

from fluidized-tanks.