romanov / percentagenet Goto Github PK

Hello!

I saw your extensions here: 25b4a01

Looks good - do you mind if I clean your code up a little and add some unit tests in my PR? I can also add some more extension methods, and other features like (the option for) dependency injection for singleton instances - so the user can decide if they want to use the DI version, or static.

I want to also:

• Add a solution (its standard)
• Add unit tests
• Change structure to something more standard, like this repository: https://github.com/fluxera/Fluxera.Repository
  • /src/<library>
  • /tests/<unit-tests>
  • / build and other metadata things
  • /assets/ I found an icon that you can use that I can add here
  • Other 'standard' things like this

I plan to have these all in my PR tomorrow

Icon:

GREAT LIBRARY!

This is so simple, yet so difficult at the same time. I can't believe no one has made a simple library like this earlier. Thank you!!

I see on the roadmap "More Helper Classes"

What do you have in mind?

I would love to contribute some code and pull-requests.

Thanks!

Hello!

I was setting up CI / CD with GitHub actions - and I need a nuget API key to do this. I see that you published this previously under your nuget account.

Can you please create a nuget API key then add it under 'secrets'? I do not think I have the option to do this.

Here are some screenshots and links to help you:

https://docs.github.com/en/actions/security-guides/encrypted-secrets

Once you add the key, please let me know what the name of the key is (not the value) so that I can add it to the CI / CD pipeline.

Thanks

Hello!

I can update this to net7 - I have a PR ready

What type of build pipeline do you use? Do you mind giving me access to it, or at least access to 'view' it so that I can make the net7 changes?

You'll still have permissions of course to 'run' the pipeline, I just want to make sure all things are built correctly with the various frameworks.

Thanks!

Why not create a type that represents a percentage instead?

// Creation
var p = Percentage.Parse("3.14");  // Parse: 3.14%;
var p = Percentage.Parse("3.14%"); // Parse: 3.14%;
var p = Percentage.Parse("31.4‰"); // Parse: 3.14%;
var p = 3.14.Percent(); // Extension on double: 3.14%;

// Manipulation
var p = 13.2.Percent();
p++; // 14.2%;
var total = 400;
total *= 50.Percent(); // Total = 200;
var value = 50.0;
value += 10.Percent(); // value 55;

var rounded = 17.56.Percent().Round(1); // 17.6%;

var perMille = 15.5.Percent().ToString("PM"); // 155‰
var perTenThousand = 0.34.Percent().ToString("PT"); // 34‱

Like this one Qowaiv.Percentage.