rollout / rox-php Goto Github PK

I have validated this will multiple payloads, and the only one that won't fail is an empty object.

The entirety of the string has the quotations escaped, and the local Roxy server returns the values as you would expect to see them for it to be resolved correctly as a string value.

Example response JSON from the /flags endpoint (showing only the flag in question):

{
    "flagName": "dev.openfeature.object_flag",
    "expression": "\"{\"name\":\"OpenFeature\",\"version\":\"1.0.0\"}\"",
    "lastModifiedDate": "2022-11-17T00:50:01.549Z"
}

This likely has something to do with the string processing post response. With the empty object example I do resolve the value and can json_decode into an array.

• We will make sure that the docs state that you must do Rox::register and Rox.setCustomProperty before doing Rox.setup
• Dynamic api will not not update the flags on the dashboard
• send state only on the setup command and eliminate all the code that does it differently

According to Guzzle docs, the default timeout is 0, which will wait indefinitely for the response.
Since it seems no timeout is being set here, in case CloudBees call times out, the caller will hang forever instead of assuming the default value.

Between versions 5.0.2 and 5.0.3, this library updated the dependency for kevinrob/guzzle-cache-middleware from ^3.2 to ^4.0. See: 5.0.2...5.0.3#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R37

The upgrade to v4 contains backwards-incompatible changes that require the cache to be cleared at the time of deployment as described here: Kevinrob/guzzle-cache-middleware#172. As mentioned in the comments, "it's especially... dangerous, because more often it may affect production than test or dev environments."

Use caution when upgrading to version v5.0.3, as you must clear the cache after implementing these changes.

Tests are failing currently if running them by PHP v8 interpreter.

Need to add PHP v8 support + setup automatic test run for it.