rollout / rox-go Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 6.0 8.54 MB

License: Other

Go 99.95% Shell 0.05%

rox-go's People

Contributors

Stargazers

Watchers

Forkers

rajdavies apg84 valery-barysok andy-a-o chippyash agentgonzo

rox-go's Issues

Inconsistent flag values

We're initializing rollout like so:

// domain/flags.go

package domain

import (
	"github.com/rollout/rox-go/v5/server"
)

var (
	Flags = &RolloutFlags{
		EnablePostManualTableRatings: server.NewRoxFlag(false),
	}
)

type RolloutFlags struct {
	EnablePostManualTableRatings server.RoxFlag
}

// rollout.go

import (
	"github.com/rollout/rox-go/v5/server"
	"solaireresort.com/playerrating/config"
	"solaireresort.com/playerrating/handler"
)

func rolloutInit() {
	newRox := server.NewRox()
	newRox.Register("playerratings.playerrating.domain.Flags", domain.Flags)
	<-newRox.Setup(config.RolloutEnvironmentKey, nil)
	handler.Rox = newRox
}

And the time we check the flag

// handler/handler.go

...

Rox.SetCustomStringProperty("playerratings.playerrating.proto.playerrating.Enriched.TableId", e.TableId)
if domain.Flags.EnablePostManualTableRatings.IsEnabled(nil) {
        // fire!!
}

...

It works but, sometimes returned flag values are not accurate. Example,