rodeoclash / vodon-pro Goto Github PK

So I just want to review my own vod, which i recorded. I import the mp4 file. Go to review. I press space and it works, but the moment I try to scrub or use arrow keys the video freezes. I cant go front or back anymore.

Place next / previous buttons on the bookmarks.

Makes it harder to tell which video is which without the duration of it somwhere.

I do a lot of coaching for fighting games and I do VOD review seasons currently using video speed controller/youtube/discord.

During my VOD reviews I frequently change speeds very high to get through downtime and catch nuances in gameplay that are difficult to catch in normal speed.

The last VOD review site that I tried was Flowfeedback, but that one didn't go passed 2x speed so I'm making a request to go to about 6X speed at maximum.

Thank you so much for making this tool as it will help me with coaching a lot of players!

Problem

If I have a drawing tool selected, play the video then pause it again, the tool is deselected the next time I go to use it.

Solution

When clearing the drawings, we should not reset the drawing tool that's selected.

Drawing in Vodon Pro exists in two modes. They are:

1. Ad-hoc drawing. Used on random frames to help illustrate a point that the coach is talking about in a review session.
2. On bookmarks (once #7 is merged). These are linked to a bookmark and created ahead of doing the review session.

Currently the system of toggling on the bookmarks was designed for "1". Coaches would toggle on the drawing tools as needed. This was built this way as the drawing tools obscure the video so they had to be turned on as needed. As the bookmarks have been expanded, it's grown increasingly "clunky" to work with this system.

Instead of toggling the controls on and off (and having them obscure the video) they instead should be on all the time and moved out of the video player area(think Adobe Photoshop-esque control panels) to be alongside it. This allows the drawing tools to be present all the time. Once always present, the saving behaviour should be altered to automatically save the drawing if the user is on an active bookmark or to create an ad-hoc drawing if the user is not on a bookmark.

Idea

Currently, you have this topbar (with File, View and Help), and a statusbar (with Setup, Review, etc). It would look nicer if those are melted into 1, similar to how discord does it.

When paused, keep frame by frame navigation. When playing, arrow keys should skip 10 seconds.

When adding multiple videos at once, prompt the user if they want to replace the existing ones (if some already exist)

Some users use the bookmark system to indicate important events in the match but don't need to add a reminder to them. We need to think of a way of separating the bookmarks from the content.

When going fullscreen, remove everything.

This might need discussion, or throw it out and see how people respond.

Hitting enter on the edit form should close it.

The file where the change needs to be made is VideoAligner.tsx

This can be done by binding a hotkey using the react-hotkeys-hook library (see Hotkeys.tsx for examples of use) that when enter is clicked the modal is closed. You can use the existing handleClose function to do this.

Note: VideoAligner.tsx still has some Typescript errors in it from the conversion over to the electron-builder template which is much stricter about standards. These either need to be cleaned up or ignored on check-in.

Building a recording client in Overwolf would allow us to capture events that occur in the game (i.e. deaths, damage done etc). This could then be displayed as general stats / charts of things that had happened over the course of the match. If we start to build some functionality around managing a team roster then we could associate these stats with players over time.

That said, Overwolf is not a popular product. Any usage of it should be not be a requirement for this tool, but an enhancement of existing video data.

We starting to get a lot of keyboard shortcuts. We should have a help menu on the review page like we do on setup (try and unify how this is launched too).

Should display on first load and inform users on shortcut keys.

Sidebar position is lost after navigating away, should be in the store so its persisted

Drawings should be hidden when the user seeks on the timeline vs. exiting the bookmark (when we don't clear drawings on playback).

When activating arrow key navigation with the video playing, pause the video.

Should calculate the width of the sidebar automatically based on window dimensions.

Should allow users to drag a handle backwards and forwards to adjust the width.

What it says on the tin

Should be able to use keys 1 - 9 to switch viewpoints.

Should be able to select people from menu at the top of the screen.

Clearing drawings when the player moves frames should be toggable.

Once videos are aligned, should be able to use the tool to composite together all the videos and export it as a movie file.

Problem

When reviewing footage, it would be helpful to have the system pause when encountering a bookmark without me having to do it myself.

Solution

A setting which enables pausing automatically on bookmarks for the current player.

Currently having two videos gives a weird distribution of them. They should be aligned to the top of the screen.

If I create a drawing in the system then click on a bookmark, my existing drawing should not be removed. Instead, the bookmark should be loaded and the drawing attached to it.

Currently, bookmarks are only visible when viewing a particular video (i.e. the video that the bookmarks belong to).

One solution to this is to show "ghost" bookmarks on the global time control. Videos that have bookmarks but aren't the video being shown will start have a bookmark icon on the timeline, just "ghosted" out (i.e. 50% opacity) that indicate a bookmark is present but not currently being viewed.

Also to think about

1. This doesn't solve the issue of a lot of bookmarks being used and crowding out the timeline (Kilk had this problem). We might want to think about reducing the size of the bookmarks or lifting them off the timeline in some way to solve this. However, it does solve the issue of having a moment you want to talk about which is attached to another video.

2. How will this play if we have other items on the timeline (i.e. deaths)

Select the arrow tool and draw out multiple arrows. Even though no handles are present on the last arrow, changing the colour still seems to update the arrow for some reason.

Analytics would make it a lot easier to design functionality. Should allow users to opt in to collecting them in the settings and on load of the tool.

Needs investigation but pen colour seems to reset when using ctrl-z

Remove arrow key toggle from settings (but keep jump distance).

A + D should be used for jump, W + S for frames.

Currently going full screen uses the videos native controls. This should be changed to use a set of custom floating video controls and the drawing etc brought back.

Controls should fade in / out like the native controls do.

• Currently you can "scroll" the mouse wheel up and down to move the drawings. This should be disabled.
• Should remove the notes feature from TLDraw
• Bring back the curved arrows

Idea

Currently, the volume doesn't get saved when swapping clips, I think it would be handier to have this saved globally instead of on a clip to clip basis.

Example

I adjust volume in this clip.


Delete the clip.

Put in another clip.

And the volume is raise to the default value again.

Idea

The application doesn't start in full-screen, it leaves gaps around the outside. I think it would make more sense to start maximized or to make the startup view smaller (like discord does), but maximized seems more logical for the use case of the app.

When mousing over the timeline, it will show a broken image / out of date image.

This should having a loading animation added to it.

This can be useful for drawing on maps or other things that are animating.

System: Win10 & MacOS(arm64)
Version: 1.9.4
Issue: Sound only but no image shown.
codec information:

Playing Screenshot:

Tried to put FFMPEG64.DLL in the installation folder, doesn't help.

Need to slow down the speed that the frame advance and rewind is called (perhaps a throttle?)

Should be able to choose between 1up (1 big, n number of small videos) and grid (all videos with equal sizes) when on the review page.

Idea

Currently, when you scrub through a clip, the clip will be paused after clicking on the timeline. It would feel more natural that the video keeps playing if the video was playing before the scrub happens.

Issues

If I understand correctly, the current implementation pauses because of performance limitations. I have also encountered issues with this, sometimes after scrubbing and quickly pressing play, the clip will play a second of where you were in the clip before jumping to the correct spot. Sometimes it doesn't even jump at all, this can be fixed by quickly pressing pause and play again, then it will jump.

Should be able to open multiple videos from explorer right click menu.
Should handle users that have set Vodon to open their video files.