rocmarchive / hcblas Goto Github PK

I think there may be an unneeded #include in the hipblas.cpp file:

https://github.com/ROCmSoftwarePlatform/hcBLAS/blob/master/lib/src/hcc_detail/hipblas.cpp#L3

On ROCm 1.5's HIP, I get this error when building hcblas:

/root/hcblas/lib/src/hcc_detail/hipblas.cpp:3:10: fatal error: 'hip/hcc_detail/hcc_acc.h' file not found

After removing that specific include statement, the hcblas build is successful.

Definitions of hipblas* functions in /lib/include/hcc_detail/hip_blas.h and in /lib/include/nvcc_detail/hip_blas.h are not the same: in certain places const qualifiers are missing in /lib/include/nvcc_detail/hip_blas.h. I'm not sure why those const qualifiers were removed since corresponding cublas* functions have them.

For example: hipblasSgemm

I was testing with master branch, and here is the error messages:
[ 50%] Building CXX object lib/src/CMakeFiles/hipblas_nvcc.dir/nvcc_detail/hipblas.cpp.o In file included from /opt/rocm/hip/include/hip/hip_complex.h:30:0, from /root/hcBLAS/lib/src/../include/nvcc_detail/hip_blas.h:25, from /root/hcBLAS/lib/src/../include/hipblas.h:59, from /root/hcBLAS/lib/src/nvcc_detail/hipblas.cpp:22: /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h: In function 'float hipCabsf(hipFloatComplex)': /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h:67:20: error: 'p' was not declared in this scop e return cuCabsf(p, q); ^ /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h:67:23: error: 'q' was not declared in this scop e return cuCabsf(p, q); ^ /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h: In function 'hipDoubleComplex hipCsqabs(hipDou bleComplex)': /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h:89:22: error: could not convert '(cuCabs(z) * c uCabs(z))' from 'double' to 'hipDoubleComplex {aka double2}' return cuCabs(z) * cuCabs(z); ^ /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h: In function 'hipDoubleComplex hipCfma(hipCompl ex, hipComplex, hipComplex)': /opt/rocm/hip/include/hip/nvcc_detail/hip_complex.h:127:26: error: could not convert 'p' from 'hipC omplex {aka float2}' to 'cuDoubleComplex {aka double2}' return cuCfma(p, q, r); ^

Here is my build script:

cd ~ && git clone -b master https://github.com/ROCmSoftwarePlatform/hcBLAS.git
cd hcBLAS && ./build.sh
dpkg -i build/*.deb
cd /opt/rocm/hcblas/lib && ln -s libhipblas_hcc.so libhipblas.so

When running build.sh, I get the following error:

Run CPack packaging tool...
CPack: Create package using DEB
CPack: Install projects
CPack: - Run preinstall target for: Project
CPack: - Install project: Project
CPack: Create package
CPack: - package: /home/sthornto/hcBLAS/build/hcblas-master-eec6c26-Linux.deb generated.
CPack: Create package using TGZ
CPack: Install projects
CPack: - Run preinstall target for: Project
CPack: - Install project: Project
CPack: Create package
CPack: - package: /home/sthornto/hcBLAS/build/hcblas-master-eec6c26-Linux.tar.gz generated.
[ 51%] Built target hipblas_hcc
[100%] Built target hcblas
./build.sh: line 153: cd: /home/sthornto/hcBLAS/build/packaging/: No such file or directory

For my own build, I can just hack build.sh to create the proper directory, but I don't know if this is the correct long term solution.