roborourke / wp-graphql-meta Goto Github PK

Hi,

Firstly, great little plugin.

I was having trouble adding a meta field for a custom post type. After some debugging, I found that the plugin is being loaded before the custom post types are.

Issue
The plugin instantiates on graphql_init, which I think is the locigal place to hook in. However, wp-graphql instantiates on after_setup_theme, which is before custom post types are added on the init hook.
https://codex.wordpress.org/Plugin_API/Action_Reference

So even though you register your meta field through the register_meta function, it won't get added because the post type hasn't been added yet.

Solution
Moving the plugin to load on do_graphql_request instead of graphql_init seems to do the trick. I'm unaware of any side effects by doing this, if there are any.

I would sugget to either move the plugin to load on do_graphql_request. If this is not a good solution please let me know and I'll prepare a PR for wp-graphql with solution for a second hook that fires on init.

Regards,
Rasmus

Once I activate the plugin, the wp_graphql IDE won't load its schema.

/index.php?gql:1 Failed to load resource: the server responded with a status of 500 (Internal Server Error)
invariant.mjs:6 Uncaught (in promise) Error: Invalid or incomplete introspection result. Ensure that you are passing "data" property of introspection response and no "errors" was returned alongside: { status: 500 }
    at r (invariant.mjs:6)
    at r (buildClientSchema.mjs:27)
    at App.js:181

WordPress 5.6
WP GraphQL 1.0.3