Giter Club home page Giter Club logo

Comments (2)

jonathanlew avatar jonathanlew commented on July 25, 2024 1

Thanks for the explanation. I added package to the ssl_gc protobufs and that works in our repo. For C++, package gets compiled into namespaces, so enums aren't a problem at all. For example, assuming package SSL;, the C++ type for the Team protobuf message would be SSL::Team. That fixes my problem, so closing this issue

from ssl-game-controller.

g3force avatar g3force commented on July 25, 2024

I removed the SSL_ prefix intentionally, because it is not a valid name according to the protobuf naming convention: https://developers.google.com/protocol-buffers/docs/style#message_and_field_names

If you do not want to refactor your code, you can just rename the field in your codebase. The message and field names are not part of the API.

Name conflicts can easily be solved using packages, as the GC does with go_package and for example the TIGERs AutoRef does with package: https://github.com/TIGERs-Mannheim/AutoReferee/blob/master/modules/moduli-referee/src/main/proto/ssl_gc_referee_message.proto#L3

One difficulty are enums indeed. They must be unique outside packages as well. I think that's why the Team is in a common package. Is this an issue in your code base as well? And if so, can't you reuse the Team and/or RobotId?

from ssl-game-controller.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.