robmaunder / polar-3gpp-matlab Goto Github PK

Thank your work!
When I run plot_SNR_vs_A.m,a error occur.
Error in the line 60 ,info_bit_pattern =get_3GPP_info_bit_pattern(K,N,E),it says I should be no greater than N(line 57)
And in function get_3GPP_info_bit_pattern, I is the input parameter K,and N is generated by N = length(Q_N)(line49) ,Q_N is input parameter N. And N is generated by N = get_3GPP_N(K,E,n_max)(In line58, plot_SNR_vs_A.m). So N is a integer number,and after length(),N is always equal 1. I think it is reason.
In PDCCH_encoder.m or other procedure, Q_N is generated by get_3GPP_sequence_pattern(N), it is a vector , so can be use in get_3GPP_info_bit_pattern(K,N,E). And parameter 'mode', it is also not used in plot_SNR_vs_A.m.
Maybe it is a small mistake, or a something right but I have not understand.

The CRC bits by the below code don't match those calculated using other ways:

% Generate the CRC bits.
G_P = get_crc_generator_matrix(A+P,crc_polynomial_pattern);
crc_bits = mod([ones(1,P),a]*G_P,2);

If these lines are changed to either:

% Generate the CRC bits.
G_P = get_crc_generator_matrix(A,crc_polynomial_pattern);
crc_bits = mod(a*G_P,2);

or

% Generate the CRC bits.
G_P = get_crc_generator_matrix(A+P,crc_polynomial_pattern);
crc_bits = mod([zeors(1,P),a]*G_P,2);

the results will match. The first method is used in other encoders (DCA, PCCA etc).

Can polar code be used with MIMO now? I've searched a lot, it seems that in 5g nr polar code can not be used with MIMO, there's only 1 antenna port for polar code right?

I am a rookie in new radio.
In plot_BLER_vs_SNR.m ,I find the LLR vector be caculated by your method(In line 151-154).
But I find some paper,the LLR in QPSK modulation,use 'ln' to caculate,and you donot use it.
can you tell me why? thank you!

When I directly call the PUCCH_encoder.m and PUCCH_decoder.m, only 15 (32,16) polar blocks can be encoded or decoded per second. After reading the code, I have found an interesting point that the path 'component' will be added every time the encoding and decoding function is called. After moving the corresponding codes to top file to make them be called only once, the speed can be improved by up to 100 times (about 2000 blocks per second). So, I think this may be taken into consideration in your future revision.