Giter Club home page Giter Club logo

Comments (3)

robinmoisson avatar robinmoisson commented on May 20, 2024

Thanks for the idea @royfrancis. It looks to me like this should be covered by using a custom password_template, which people can do. Do you see advantages to the --css solution you consider important?

from staticrypt.

royfrancis avatar royfrancis commented on May 20, 2024

Ideally, I think the template should be split into html, js and css. That makes it more flexible to make changes. Most people would want to change styling with css. The next level would be change the layout of the form (html). It's unlikely that the js would need to be changed.

Personally, I like the idea to using bootstrap for styling. Removing the current styling and including the boostrap js and css to the html head makes it fit better with my project.

Screenshot from 2023-03-27 13-31-26

from staticrypt.

robinmoisson avatar robinmoisson commented on May 20, 2024

Hey @royfrancis , thanks for detailing and the pic - those rounded corners look good too.

I think allowing to set the full template as html is simpler. If the user wants to write code to customize the display we just hand over everything to them and they can edit the file however they want. Allowing to edit just the css doesn't feel like it makes things much simpler than editing the html to me and it's also more brittle: if I want to change something in the default password template later, having an external CSS file that point to it that I don't control means any change might break the CSS.

Better for the two choices to be all-in, "use the full default template" or "use your own full custom template" I think.

from staticrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.