robinlovelace / opengeohub2023 Goto Github PK

Hi Robin! Some comments:

1. opengeohub2023/osm.qmd

   Lines 36 to 40 in 4ad8ad5

   	Note: as of 2023-08-31 you also need to install the development version of `sf` as follows:
   	```r
   	remotes::install_github("r-spatial/sf")
   	```

Did you add this part because of the issues that we had with layer/type or some other reasons?

2. opengeohub2023/osm.qmd

   Line 90 in 4ad8ad5

   As outlined in the [`providers_comparison`](https://docs.ropensci.org/osmextract/articles/providers_comparisons.html) vignettte in the [`osmextract`](https://docs.ropensci.org/osmextract/) package, there are several providers of OSM data. The main ones that provide regular extracts without need for logins are:

It should be "vignette" instead of "vignettte"

3. opengeohub2023/osm.qmd

   Line 152 in 4ad8ad5

   It can be noticed that there are several holes (such as Peru, which is the reason why, in the first example, Lima was matched with South America data), implying that `openstreetmap_fr` cannot always be used for geographical matching of a `place`.

I think this sentence is a bit out of context and should be adjusted (since you never speak about Peru)

I checked until line 186, I'll check the rest later today!

@Robinlovelace I now try to reproduce the blog post run, and the quarto returns an error:

34/69 [unnamed-chunk-17]

Quitting from lines 242-247 [unnamed-chunk-17] (blog.qmd)
Error in `py_call_impl()`:
! FileNotFoundError: [Errno 2] No such file or directory: 'data/gtfs/stops.txt'
Run `reticulate::py_last_error()` for details.
Backtrace:
  1. global .main()
  2. execute(...)
  3. rmarkdown::render(...)
  4. knitr::knit(knit_input, knit_output, envir = envir, quiet = quiet)
  5. knitr:::process_file(text, output)
     ...
 14. knitr (local) engine(options)
 15. reticulate::eng_python(options)
 16. reticulate:::py_compile_eval(snippet, compile_mode)
 19. builtins$eval(compiled, globals, locals)
 20. reticulate:::py_call_impl(callable, call_args$unnamed, call_args$named)

Heads-up @JosiahParry I'm going to give this a go.

Seems it needs JuliaCall: https://github.com/Robinlovelace/opengeohub2023/actions/runs/6025986709/job/16347926866#step:11:541

crsuggest suggests several CRS that are deprecated (outdated). I think you should prefer:

ETRF2000-PL / CS92 (EPSG: 2180) - CRS for the whole Poland (I use it in my materials),ETRF2000-PL / CS2000/18 (EPSG: 2177) - CRS for the 18 degree meridian.

Thanks @kadyb for the local geo knowledge : )

So far the content in tidy.qmd has focussed on a tiny dataset.

It's time to add a bigger dataset. To make R/Python translation easier, the plan is to use the same dataset as put together by @michaeldorman.

A step towards #35. You up for giving this a bash @evetion ?

As documented here (finally found it): https://quarto.org/docs/output-formats/html-basics#tabsets

There are too many lines of code in R and Python code for joining.

See https://github.com/Robinlovelace/opengeohub2023/blob/main/blog.qmd

Building on #34 by @evetion

As shown below, Reopen in Devcontainer fails locally.

No idea why, as it works on Codespaces: https://codespaces.new/Robinlovelace/opengeohub2023