No function clause matching in Moebius.Extensions.DateExtension.decode/4 about moebius HOT 3 CLOSED

I find it odd this hasn't created trouble before now... @nurugger07 I won't be able to look at this until at least tonight. If you have the fix, and want to get it up there, do so. I can then try to break it ;-)

Otherwise I'll see what I can figure out. My only concern I guess is that this was something intentional, which has somehow become broken, or just an oversight back when @robconery was experimenting putting together the custom date extensions.

from moebius.

@nurugger07 - I think your suggested fix of modifying the function signature is the simplest, most sensible fix. My understanding is that the use of timestamp is less then ideal in the majority of use cases, but we should probably cover it.

It would surprise me not at all to learn that @robconery made a tactical decision not to handle that type specifically, given his convictions about dates and timezones (which I share).

I believe the decoding itself is valid in either case, so doing:

def decode(%Postgrex.TypeInfo{type: timestamp},<<microsecs :: int64>>, _, _) when timestamp in ["timestamptz", "timestamp"] do

should do it. I Think. I did it locally, and added a test that passes.

from moebius.

This can be closed now. I fixed it with #62

from moebius.