Comments (4)
Ha! Gentle... I've been meaning to fix this. I have a bunch of stuff scattered on the floor for v4 so I'll have a look then. Thanks :).
from moebius.
Yeah it looks like the query just goes with some SQL and doesn't follow conventions... I think. It's been a while since I dug in but here's the code for search:
https://github.com/robconery/moebius/blob/master/lib/moebius/query.ex#L257
The run
command should be resolving to here:
https://github.com/robconery/moebius/blob/master/lib/moebius/database.ex#L39
The problem appears to be that nothing is "building" the query since the sql
parameter is already set. That's matching this:
https://github.com/robconery/moebius/blob/master/lib/moebius/database.ex#L199
Which just fires the SQL without additional building. One way I can think of doing this is to set the type
of the query to search
or something, so it can be matched like this:
https://github.com/robconery/moebius/blob/master/lib/moebius/database.ex#L38
If search
is matched then we could pipe the query to a transform that checks for limit
(I don't think anything else is appropriate).
Would love some help on this...
from moebius.
Hi Rob,
I have been learning Elixir and thought I might try Moebius. I saw this issue and thought I might try to help (This is the first time I have even thought about contributing so please be gentle).
I went through your links above and traced the steps through the pipes, it seems that you are building up the cmd with the limit function adding the value to the map/struct here:
https://github.com/robconery/moebius/blob/master/lib/moebius/query.ex#L88
It is then matched here:
https://github.com/robconery/moebius/blob/master/lib/moebius/database.ex#L232
But there is no function that accounts/matches when there is a value for limit
. So the fix would be to match the limit in cmd
when building the SQL. you think I am on the right track I might have a go at contributing. Let me know what you think.
from moebius.
OK. If you need a hand with anything let me know.
from moebius.
Related Issues (20)
- Update library HOT 5
- Make PostgresTypes configurable HOT 1
- Any plans of going to postgres 0.16.x HOT 6
- How do I ACTUALLY use it HOT 7
- Inflex not loading
- Does Moebius sanitize user input? HOT 5
- What does this error mean? HOT 12
- Hang problem. HOT 1
- run_with_psql doesn't use the configured connection info HOT 3
- Updating array column: HOT 8
- readme talks about existence operator, but doesn't show it? HOT 4
- Async test HOT 2
- `pool_mod` option does not work HOT 11
- Allow caching query information
- Is is possible to run moebius and ecto together? HOT 1
- Return values for IO actions HOT 2
- Dependency conflict with phoenix in umbrella app HOT 1
- Date Test Fails
- Moebius.DocumentQuery return only one entry? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moebius.