Giter Club home page Giter Club logo

Comments (21)

iamareebjamal avatar iamareebjamal commented on June 9, 2024 1

When we upgraded rest of our dependencies, including the handlebars one, it automatically started working for us, the previous version as well. Unfortunately, that was a busy week and we couldn't notice exactly which dependency upgrade fixed it

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

@Redsandro the tests are passing back to Ember 3.4 https://travis-ci.org/shipshapecode/ember-math-helpers, so I think there may be more at play here and/or there is something about 3.7 specifically that doesn't work.

from ember-math-helpers.

Redsandro avatar Redsandro commented on June 9, 2024

@rwwagner90 Possibly. I can't figure out why this is happening though. Does the message "Cannot read property 'getHash' of null" ember-math-helpers/helpers/abs.js give you any idea about where I should be looking?

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

It does not. There is nothing in https://github.com/shipshapecode/ember-math-helpers/blob/master/addon/helpers/abs.js that uses anything called getHash. Is it possible to get a small, isolated reproduction we could look at? It's also possible there was a bug in Ember itself in 3.7. Would you be able to use 3.8?

from ember-math-helpers.

Redsandro avatar Redsandro commented on June 9, 2024

Sorry for not getting back to you earlier. I was traveling. This is definitely still an issue and it's weird that I can get it to work by downgrading ember-math-helpers.

I'm a long time Linux user, but Ember feels a bit like Windows in the old days, where over time, updates cause more and more inexplicable errors to the point of needing a fresh install.

With Ember Octane out, I think it might be time to do a 'fresh install'.

I will close this issue for now.

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

@Redsandro if you can reproduce in a small, self contained, app, let me know.

from ember-math-helpers.

iamareebjamal avatar iamareebjamal commented on June 9, 2024

Happening for us as well

ERROR Summary:

  - broccoliBuilderErrorStack: TypeError: Cannot read property 'getHash' of null
    at hashForDep (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/hash-for-dep/index.js:67:24)
    at optionsHash (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/lib/options-hash.js:58:51)
    at Babel.optionsHash (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/index.js:117:26)
    at Babel.cacheKeyProcessString (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/index.js:124:15)
    at Object.processString (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:30:19)
    at Processor.processString (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/lib/processor.js:19:27)
    at /home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/index.js:353:16
    at initializePromise (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/node_modules/rsvp/dist/rsvp.js:520:5)
    at new Promise (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/node_modules/rsvp/dist/rsvp.js:995:33)
    at invoke (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/index.js:352:10)
  - code: [undefined]
  - codeFrame: Cannot read property 'getHash' of null
  - errorMessage: ember-math-helpers/helpers/abs.js: Cannot read property 'getHash' of null
        in /tmp/broccoli-27396gIn7cjRKlxLh/out-457-funnel_funnel_addon_js
        at broccoli-persistent-filter:Babel > [Babel: ember-math-helpers] (Babel: ember-math-helpers)
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: ember-math-helpers/helpers/abs.js
    - line: [undefined]
    - treeDir: /tmp/broccoli-27396gIn7cjRKlxLh/out-457-funnel_funnel_addon_js
  - message: ember-math-helpers/helpers/abs.js: Cannot read property 'getHash' of null
        in /tmp/broccoli-27396gIn7cjRKlxLh/out-457-funnel_funnel_addon_js
        at broccoli-persistent-filter:Babel > [Babel: ember-math-helpers] (Babel: ember-math-helpers)
  - name: BuildError
  - nodeAnnotation: Babel: ember-math-helpers
  - nodeName: broccoli-persistent-filter:Babel > [Babel: ember-math-helpers]
  - originalErrorMessage: Cannot read property 'getHash' of null

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

@iamareebjamal can you provide any details? Ember version, ember-cli version, custom broccoli stuff you might be doing, etc?

from ember-math-helpers.

iamareebjamal avatar iamareebjamal commented on June 9, 2024

"ember-cli": "~3.10.1"

Using broccoli-persistent-filter

The project is open source. This is the PR - fossasia/open-event-frontend#3873

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

My guess would be something with broccoli, babel, or the htmlbars update, but I don't really know. I've been using it without any issues in several projects. It might be that you are using broccoli-funnel and this addon is not compatible with the version or something. @Redsandro thoughts?

from ember-math-helpers.

Redsandro avatar Redsandro commented on June 9, 2024

One guess is that a certain dependency is too new. But I'm grasping straws, I couldn't figure it out.

v2.10.0...v2.11.0 see package.json

from ember-math-helpers.

iamareebjamal avatar iamareebjamal commented on June 9, 2024

It's working for 2.11.1 for us. Breaking on latest

from ember-math-helpers.

iamareebjamal avatar iamareebjamal commented on June 9, 2024

Starts breaking from 2.11.2

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

@iamareebjamal no real changes between those two versions, except maybe ember-cli-babel version v2.11.1...v2.11.2#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R32

Unless you are perhaps using node older than 8.x? We did drop support for node 6 there.

from ember-math-helpers.

iamareebjamal avatar iamareebjamal commented on June 9, 2024

Node 12. There are other dependency updates as well. But yes, no such code change. Nevertheless, for some reason, babel can't find this module for hashing

from ember-math-helpers.

Redsandro avatar Redsandro commented on June 9, 2024

Is it relevant that

  • I was using Ember 3.7 and the update broke when emh updated dependency ember-source from 3.7 to 3.9
  • @iamareebjamal was using Ember 3.10 and emh 2.11.1 had dependency ember-source 3.9 updated to 3.15 in latest?

Perhaps ember-source used breaks compatibility with older versions of Ember?

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

@Redsandro no ember-source is a devDep and does not get shipped.

from ember-math-helpers.

Redsandro avatar Redsandro commented on June 9, 2024

Yeah makes sense. It's puzzling.

So this issue is now confirmed, but it's hard to figure out why it is occurring. It could very well be an upstream issue, but so far the only plugin that I encountered needed special care (trial and error) when upgrading was ember-math-helper. Because the usual problem for other plugins is the other way around: newer Ember version might break them.

I figured it was easiest to reinstall a fresh copy of everything without upgrading for my app and then copy over the relevant files (and edit where necessary).

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

It's likely the custom whitelist / blacklist stuff we provide, so you don't have to ship all the helpers. That's the only thing different than any standard addon. I mostly copied it from here https://github.com/DockYard/ember-composable-helpers/blob/master/index.js so maybe we should update things to match theirs more closely and see if it helps.

from ember-math-helpers.

RobbieTheWagner avatar RobbieTheWagner commented on June 9, 2024

Can you guys try 2.13.0 and see if anything is different?

from ember-math-helpers.

Redsandro avatar Redsandro commented on June 9, 2024

2.13.0 works for me on a different app. I am not be able to check the exact same app with the exact same dependencies that had the issue in the fist place, because that one had since been upgraded from Ember 3.7.

Thank you again @rwwagner90 for looking into this.

Update

Nope, 2.13.0 does not fix the issue. In my last active Ember 3.7 project, I still cannot use any ember-math-helpers newer than 2.10.0.

  - broccoliBuilderErrorStack: TypeError: Cannot read property 'getHash' of null
    at hashForDep (/app/node_modules/hash-for-dep/index.js:67:24)
    at optionsHash (/app/node_modules/ember-math-helpers/node_modules/broccoli-babel-transpiler/lib/options-hash.js:58:51)
    at Babel.optionsHash (/app/node_modules/ember-math-helpers/node_modules/broccoli-babel-transpiler/index.js:117:26)
    at Babel.cacheKeyProcessString (/app/node_modules/ember-math-helpers/node_modules/broccoli-babel-transpiler/index.js:124:15)
    at Object.processString (/app/node_modules/ember-math-helpers/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:41:19)
    at Processor.processString (/app/node_modules/ember-math-helpers/node_modules/broccoli-persistent-filter/lib/processor.js:24:27)
    at resolve (/app/node_modules/ember-math-helpers/node_modules/broccoli-persistent-filter/index.js:433:16)
    at initializePromise (/app/node_modules/ember-math-helpers/node_modules/rsvp/dist/rsvp.js:523:7)
    at new Promise (/app/node_modules/ember-math-helpers/node_modules/rsvp/dist/rsvp.js:1017:35)
    at invoke (/app/node_modules/ember-math-helpers/node_modules/broccoli-persistent-filter/index.js:432:10)
  - code: [undefined]
  - codeFrame: Cannot read property 'getHash' of null
  - errorMessage: ember-math-helpers/helpers/abs.js: Cannot read property 'getHash' of null
        in /tmp/broccoli-1VWbDff2DKDZK/out-265-funnel_funnel_addon_js
        at broccoli-persistent-filter:Babel > [Babel: ember-math-helpers] (Babel: ember-math-helpers)
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: ember-math-helpers/helpers/abs.js
    - line: [undefined]
    - treeDir: /tmp/broccoli-1VWbDff2DKDZK/out-265-funnel_funnel_addon_js
  - message: ember-math-helpers/helpers/abs.js: Cannot read property 'getHash' of null
        in /tmp/broccoli-1VWbDff2DKDZK/out-265-funnel_funnel_addon_js
        at broccoli-persistent-filter:Babel > [Babel: ember-math-helpers] (Babel: ember-math-helpers)
  - name: BuildError
  - nodeAnnotation: Babel: ember-math-helpers
  - nodeName: broccoli-persistent-filter:Babel > [Babel: ember-math-helpers]

from ember-math-helpers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.