Tree-shaking via only / except configuration is broken in v4 about ember-math-helpers HOT 5 OPEN

@jelhan you are correct that support was dropped for it. I believe tree shaking should be automatic with embroider and only use the things you import, but I could be wrong.

from ember-math-helpers.

I believe tree shaking should be automatic with embroider and only use the things you import, but I could be wrong.

That's only true if consuming app uses Embroider and opted in to { staticHelpers: true } as far as I know.

from ember-math-helpers.

I believe tree shaking should be automatic with embroider and only use the things you import, but I could be wrong.

That's only true if consuming app uses Embroider and opted in to { staticHelpers: true } as far as I know.

That's possible, but that is the future, so I don't know if we need configs for this anymore in this addon.

from ember-math-helpers.

I don't know if we need configs for this anymore in this addon.

I think it's a maintainer decision. I see two options:

1. Document the breaking change in the changelog and update the docs. Or
2. Rollback the v2 addon conversion and restore the functionality as a bug fix.

A third one would be restoring the functionality for apps not using Embroider. This is discussed here: embroider-build/embroider#1748 (comment) It would be still a breaking change introduced in v4 but affecting a smaller subset of apps using this addon.

from ember-math-helpers.

I think documenting the breaking change is probably the best way to go here.

from ember-math-helpers.