rneomy / last.fm-scrobbler Goto Github PK

I had checked the "check manually entered details with last.fm before scrobbling". Now when listening to https://youtu.be/jRhGjPoNqBY , I got an error message bar saying the track was skipped and I "clicked to edit" to fix the title, but the message just reappears after a few seconds that the track was not found and was skipped from scrobbling.

The track details were correctly identified though as UFO and I edited the title to remove the parentheses, to "I'm A Loser" exactly as on last.fm.

I'm using the latest Firefox, and the NoScript addon, but disabling it on the tab didn't fix this.

The first track of a playlist is correctly scrobbled, or when I hit "play next", but auto-played tracks doesn't trigger this extension.

https://www.youtube.com/watch?v=X0DeIqJm4vM is a song and this scrobbler doesn't appear able to scrobble it.

So I can put in say 50% and it will scrobble the track after its halfway played

On many artists' official channels the artist metadata that this extension reads is suffixed with " - Topic", e.g. "Prince - Topic" https://www.last.fm/music/Prince+-+Topic
This should be removed when the option to clean submissions is enabled.

While the track is playing have last.fm show what your currently listening to using Now Playing Requests

Probably should have a second countdown to initiate this, so it can be shorter than the scrobble countdown?

Hello,

Thank you for the extension! I quite like it!

Is there a chance we could blacklist channels in the settings? For example, with the Entertainment section turned on, I see a lot of false-positives that I should be able to remove easily just by adding 5-10 YouTube channels in the settings instead of having to go to the Last.fm website and manually unscrobble them one by one.

When the option to clean titles before submission is enabled "(Official music video)" is handled and automatically removed, but "(Official video)" gets 'cleaned' to " video)". "(Official audio)" is similarly converted to " audio)".

It would be great, if the song info i manually edit (because auto-parse is not working well on this particular track) would be cached (the key could be URL for example), so when i play it again, it will scrobble the correct values.

For some reason, a lot of albums have the wrong category (just saw one that was labeled as People & Blogs for some reason). An option to scrobble anyway despite the category not being whitelisted would be convenient, so you don't have to go manually scrobble it if it isn't in the correct category.

Some videos like https://www.youtube.com/watch?v=SQNtGoM3FVU are marked not as music, although they clearly are

I've noticed that YouTube nowadays has a new way of handling tracks on an album. If the upload is a complete album the uploader can put timestamps with track names in the description to make the video divided by tracks as shown in the attached pic. It would be nice to get each track individually scrobbled.

In file https://github.com/rNeomy/last.fm-scrobbler/blob/master/youtube/data/inject.js, I see some manipulation of the location of the URL that the user might visit that is beyond the scope of this extension.

Can you explain why this is there?

Thanks for the extension!
I use Youtube's dark theme which makes the black text difficult to see (background is grey). It would be nice to be able to change the text colour.

Very often official music uploads (for example https://www.youtube.com/watch?v=Sdqpykf3fF4) use only the title. But below the music video there is a information in Text "Music in this video". This source can be used to identify a song.

This feature would be awesome!

Anything in brackets is usually not relevant, and resulting strings should be trimmed

for example on https://www.youtube.com/watch?v=LfephiFN76E
there are a bunch of translators in the metadata, and the first metadata that is provided is used as the category to check whether the video is music.
which will result in: "scrobbel skipped, {random translator name} category is not listed"
(firefox 69.0 64Bit, on windows 10)

probably the bug is in /youtube/data/scrobbler/protected.js at line 206.

I noticed that this script has trouble reading names from unofficial uploads. For example, https://youtu.be/y9AQYPDOCts the script tries to search for the artist "Xerf Xpec" because that's the name of the uploader, rather than Toshiki Kadomatsu. Official channels either have "Topic" in the name (automatic Youtube music uploads), or they have a badge next to their name (shows up in the html as "badges":[{"metadataBadgeRenderer":{"icon":{"iconType":"OFFICIAL_ARTIST_BADGE"},"style":"BADGE_STYLE_TYPE_VERIFIED_ARTIST","tooltip":"Official Artist Channel").

Would it be possible to adjust the script for it checks for these, and if it's not there, tries to pull the artist name from the title of the video instead?

Then again, it correctly reads the artist name in this video, so I'm not sure what's going on.
https://youtu.be/eve71DbyQ8U

Doesn't work (tries to search for artist "City Pop World"):
https://youtu.be/dQLSvvUTnYA

After accepting connection fron last.fm, the URL where my browser is redirected is invalid ( [long hex string].extensions.allizom.org ).

Hey, I've been checking through your repo due to the extension not working on my device and stumbled upon that your lastfm.js file has a variable called "lastfm" with what seems to be the public and secret tokens that give you access to the LastFM API.

From what I know, its not a big deal but as the saying goes, "its better to be safe than sorry".

My suggestion to fix this is making 1 (or 2) files with the keys and inputing the files into the .gitignore file.

You can just make an import with the keys (if i'm not wrong) and use them that way.

(re-gen your token too lol)

Consider this example: https://www.youtube.com/watch?v=O9Dcs9U7rXM

00:00 01. Bad Company - Riptide
06:40 02. Jorge Ben & Toquinho - Carolina Carol Bela (DJ Marky & XRS Remix)
11:03 03. Shy FX - Shake It
15:04 04. Un-Cut - Midnight
19:55 05. Shimon - Hush Hush
24:06 06. Stakka & Skynet & DJ Friction - Altitude
28:23 07. Future Cut - Dainjah
33:31 08. Hatiras vs. J Majik - Spaced Invader
39:00 09. Ed Rush & Optical - Kerb Crawler
44:29 10. High Contrast - Make It Tonight
50:09 11. Q Project - Trouble
54:21 12. Digital - Gateman
59:37 13. Bad Company - Miami Flashback

We could try to ignore the initial /%d%d?\./ part.

For concerts or other compilations (e.g. here), track names will not appear in the video title.

However, helpful uploaders and/or commenters may include a track list (with time stamps). While detecting and parsing such lists is a bottomless pit, I think the addon should make some effort to extract the data when given in the most common formats.

I can see the Toast function that's intended to provide some logging/info but it doesn't appear to be showing on music.youtube.com.

Perhaps they could simultaneously log to the console to help debug and diagnose issues with the extension?

Many times these are new songs to the system

Is it possible to update this plug-in to also work on music.youtube.com? It works perfectly on youtube.com, but I find that the interface on music.youtube.com is much better polished (and tailored specifically for an audio listening experience) -- would be great if this plug-in would be able to scrobble from YouTube Music.

In my options, my supported categories are "Música, Music"

However, it keeps scrobbling this video: https://www.youtube.com/watch?v=fC3pEQB3_Tc
The "Only scrobble under the following categories" checkbox is checked.

This happens because last.fm will now not receive a request with undesired fields