rlmv / doc-trips Goto Github PK

View Code? Open in Web Editor NEW

6.0 3.0 3.0 5.85 MB

DOC First-Year Trips database

Home Page: https://www.doctrips.org

JavaScript 16.77% Python 73.73% Makefile 0.10% Shell 0.01% HTML 9.12% CSS 0.26%

python django outdoors

doc-trips's People

Contributors

Stargazers

Watchers

Forkers

kellenappleton jakekl a-matusewicz

doc-trips's Issues

Make sure that all ForeignKey choices in forms display options for the appropriate TripsYear

simplify db urls to use db:view_name namespace?

Tests for CrispyFormMixin fields validation.

Use Behave (https://pythonhosted.org/behave/) for testing?

DatabaseMixin.get_form_class needs test for trips_year filtering

Write test for all list view filters

Rethink User setup. Should we implement a custom User model with a net_id field?

should permissions be in a separate app?

Format LeaderApplication templates, both for applications and grading.

LeaderApplication edit view should only be visible to the applicant. Just display a single apply/edit page. Be sure to filter by trips_year

Use `subqueries` for `get_graders`

Subqueries are new in Django 1.11

Rewrite Behave tests for permissions and access using LiveServerTestCase

DartmouthDirectory lookups need test cases

Implement error handling for ScheduledTrip Section-Template-TripsYear uniqueness constraint

Fix Application listview filters

Not sure exactly what the issue is now, but I ran into some bugs in Django last year which may now be resolved.

TripsYears are automatically added to objects in DatabaseModel.save. Should this be in the form instead, to allow editing of past years?

Database pages need to filter by trips year.

This should probably be implemented with a DatabaseAdmin class.

Should leader applications be graded by trips_year? As in, each trips year should have its own grading portal, and a landing page which redirects to the page for the current trips_year?

Rename `TripTemplate.name` to `number`

Test cases for Leader application views

use verbose_name instead of absolute_url_pattern

Use a tripsyear_modelform_factory

Upgrade all packages

Check for upgrades, test, and pin new versions.

Format `phone_number` fields properly

This probably requires some front-end work

Move LeaderApplication grade selection logic to the LeaderApplication object manager

Rewrite `display_view` logic

This is a hacky, untested mess which unfortunately powers most of the detail views on the site.

Steps:

Write some unit tests
Refactor the display view to a class so that fields can be specified declaratively, like forms.

Make sure that forms (LeaderApplication, LeaderGrade, TrippeeRegistration) add the proper trips_year to objects.

Add application extensions for specific users

Probably as a pivot table? A director should be able to specify a time by which a late application is due. This should probably be entered by NetId, in case the applicant has not yet logged into the site.

Send emails to users when they have been granted permissions

How do you put content in the issue body?

Test for DatabaseMixin .dispatch trips_year restriction

DatabaseModel documentation

separate DatabaseViewFactory into separate views, with 'url' or 'get_url' methods, returning urlregexes

implement permissions

Escape `Registration.name` in HTML

Deal with cascading ForeignKey deletes. Should we use SET_NULL?

Add filter to IncomingStudent ListView

This should show cancelled students, and probably a few other things.

Should database pages from previous years be editable?

related to #2

LeaderApplications should not have database Create or Delete views?

How do we get valid emails?

DatabaseMixin query retrieval needs tests

Make site only work with current trips year - use custom ModelAdmin class and override get_queryset

Fix IncomingStudent CSV import

See Sentry for errors. This is caused because .xls files are not supported. This can probably be handled by using a third party package,

Implement permission-granting portal

campsite admin dynamic columns need test cases

Better project layout

Flesh out LeaderApplication fields

Leader Applications: vulnerability: forms can still be submitted even when the application is closed. Change the application view to redirect to an "app closed" page instead of rendering a differenent template.