rlancaste / stellarsolver Goto Github PK

View Code? Open in Web Editor NEW

89.0 89.0 44.0 30.28 MB

License: GNU General Public License v3.0

CMake 2.79% C++ 30.97% C 65.57% Python 0.22% Perl 0.03% Shell 0.17% SWIG 0.26%

stellarsolver's People

Contributors

Stargazers

Watchers

stellarsolver's Issues

Incorrect deallocator in externalsextractorsolver.cpp

stellarsolver/stellarsolver/externalsextractorsolver.cpp

Lines 1328 to 1330 in e0aa8d3

 free(xArray); 

 free(yArray); 

 free(magArray);

free is used instead of delete [].

Resource leak in astrometry/qfit-an/qfits_image.c

stellarsolver/stellarsolver/astrometry/qfits-an/qfits_image.c

Lines 454 to 455 in e0aa8d3

 buf_out = qfits_malloc(npix * BYTESPERPIXEL(ptype)); 

 op = buf_out;

buf_out/op is lost in that function.

Resource leak in astrometry/util/wcs-pv2sip.c

stellarsolver/stellarsolver/astrometry/util/wcs-pv2sip.c

Lines 181 to 191 in e0aa8d3

 ct = fits_get_dupstring(hdr, "CTYPE1"); 

 if ((ct && streq(ct, "RA---TPV")) || forcetan) { 

 // http://iraf.noao.edu/projects/ccdmosaic/tpv.html 

 logmsg("Replacing CTYPE1 = %s header with RA---TAN\n", ct); 

 fits_update_value(hdr, "CTYPE1", "RA---TAN"); 

 } 

 ct = fits_get_dupstring(hdr, "CTYPE2"); 

 if ((ct && streq(ct, "DEC--TPV")) || forcetan) { 

 logmsg("Replacing CTYPE2 = %s header with DEC--TAN\n", ct); 

 fits_update_value(hdr, "CTYPE2", "DEC--TAN"); 

 }

ct is overwritten without being freed here.

Some C++ files built with C options

Example:

[ 22%] Building CXX object CMakeFiles/stellarsolver.dir/stellarsolver/sep/lutz.cpp.o
cc1plus: warning: command line option '-Wno-implicit-function-declaration' is valid for C/ObjC but not for C++

Resource leak in internalsextractorsolver.cpp

stellarsolver/stellarsolver/internalsextractorsolver.cpp

Lines 928 to 937 in e0aa8d3

 if (!pl_size(engine->indexes)) 

 { 

 emit logOutput(QString("\n\n" 

 "---------------------------------------------------------------------\n" 

 "You must include at least one index file in the index file directories\n\n" 

 "See http://astrometry.net/use.html about how to get some index files.\n" 

 "---------------------------------------------------------------------\n" 

 "\n")); 

 return -1; 

 }

engine is lost here.

Resource leak in astrometry/util/scamp.c

stellarsolver/stellarsolver/astrometry/util/scamp.c

Lines 27 to 34 in e0aa8d3

 scamp = scamp_catalog_open_for_writing(filename, FALSE); 

 if (!scamp) { 

 return -1; 

 } 

 if (scamp_catalog_write_field_header(scamp, hdr)) { 

 return -1; 

 }

Both hdr and scamp leak here.

StellarSolverTester incorrectly checks available memory

On Raspberry Pi4 8GB StellarSolverTester issues the following message:

Evaluating Installed RAM for inParallel Option. Total Size of Index files: 31.7369 GB, Installed RAM: 1.71799e+10 GB
There should be enough RAM to load the indexes in parallel.

Of course, it hasn't got that memory available, and, in fact, on the Pi4 8GB, any one process still only has 4GB available to it.

Most options results in a out-of-memory errors and eventually a seg fault.

Similarly, latest build of kstars from Git either fail to solve, or crash kstars when using StellarSolver.

Update input image with solution WCS?

hi everyone,

Thanks for making this available! It is difficult to set up astrometry.net on mac.

I know that this is not the goal of the project, but it would be very useful if the solution WCS could be applied to the input image for processing data after the fact. I have not seen any way to do this for standalone images in kstars either, or am I missing something? thanks!

Resource leak in astrometry/blind/verify.c

stellarsolver/stellarsolver/astrometry/blind/verify.c

Lines 86 to 89 in e0aa8d3

 if (!vf->fieldcopy || !vf->xy) { 

 fprintf(stderr, "Failed to copy the field.\n"); 

 return NULL; 

 }

vf is lost here.

Resource leak in astrometry/util/quadfile.c

stellarsolver/stellarsolver/astrometry/util/quadfile.c

Line 56 in e0aa8d3

qf = calloc(1, sizeof(quadfile_t));

stellarsolver/stellarsolver/astrometry/util/quadfile.c

Lines 76 to 79 in e0aa8d3

 if (!qf->fb) { 

 ERROR("Failed to create fitsbin"); 

 return NULL; 

 }

qf is lost here.

Uninitialised value in stellarsolver/sep/aperture.cpp

stellarsolver/stellarsolver/sep/aperture.cpp

Line 520 in e0aa8d3

segt += ssize;

There is a code path that has ssize uninitialised here. Consider initialising ssize. I can report the path, but well, just initialise please ;)

Resource leak in astrometry/blind/solvedfile.c

stellarsolver/stellarsolver/astrometry/blind/solvedfile.c

Lines 245 to 249 in e0aa8d3

 if ((fwrite(vals, 1, N, f) != N) || 

 fclose(f)) { 

 SYSERROR("Failed to write solved file \"%s\"", fn); 

 return -1; 

 }

vals is not closed on fwrite success, leaking.

Uninitialised value in sep/extract.cpp

stellarsolver/stellarsolver/sep/extract.c

Lines 720 to 721 in e0aa8d3

 if (image->noise) 

 arraybuffer_free(&nbuf);

stellarsolver/stellarsolver/sep/extract.cpp

Lines 728 to 729 in e0aa8d3

 if (image->noise) 

 arraybuffer_free(&nbuf);

If isvarnoise is false (image->noise == NULL), this free uses the unitialised nbuf struct.

Resource leak in astrometry/util/mathutil.c

stellarsolver/stellarsolver/astrometry/util/mathutil.c

Line 383 in e0aa8d3

F = malloc(3 * N * sizeof(double));

stellarsolver/stellarsolver/astrometry/util/mathutil.c

Lines 412 to 415 in e0aa8d3

 if (det == 0.0) { 

 fprintf(stderr, "ERROR (fit_transform) -- determinant zero\n"); 

 return; 

 }

F is lost here.

stellarsolver combines incompatible GPL licenses (so was rejected from Debian)

https://lists.debian.org/debian-qt-kde/2021/02/msg00114.html

in this package there are files under the GPL-2 (stellarsolver/astrometry/libkd/an-fls.h) mixed with files under GPL-3+.
According to [1] this is not allowed.

Thorsten

[1] https://www.gnu.org/licenses/gpl-faq.en.html#AllCompatibility

Also see: https://www.gnu.org/licenses/gpl-faq.en.html#v2v3Compatibility

Resource leak in internalsextractorsolver.cpp

stellarsolver/stellarsolver/internalsextractorsolver.cpp

Lines 928 to 937 in e0aa8d3

 if (!pl_size(engine->indexes)) 

 { 

 emit logOutput(QString("\n\n" 

 "---------------------------------------------------------------------\n" 

 "You must include at least one index file in the index file directories\n\n" 

 "See http://astrometry.net/use.html about how to get some index files.\n" 

 "---------------------------------------------------------------------\n" 

 "\n")); 

 return -1; 

 }

engine is lost here.

Resource leak in astrometry/util/codekd.c

stellarsolver/stellarsolver/astrometry/util/codekd.c

Lines 57 to 61 in e0aa8d3

 if (fits) { 

 io = kdtree_fits_open_fits(fits); 

 fn = fits->filename; 

 } else 

 io = kdtree_fits_open(fn);

io is lost if reading the tree fails.

CLI example

Hi, first off all this work is what i've been looking for for a long time !
thanks a lot, it works like a charm and i'm sure it's the way things should be done

Could you provide a really basic command line example ?
For example
1- open fits file
2- SEP or Solve
3- ouput results

(yes : i'm lost in Qt cutties to understand your Tester)

Thanks again
Gilles

Resource leak in astrometry/blind/engine.c

stellarsolver/stellarsolver/astrometry/blind/engine.c

Line 1055 in e0aa8d3

int job_set_output_base_dir(job_t* job, const char* dir) {

It seems path is overwritten repeatedly, sometimes not initialized properly, in that function. Code is a bit strange, I did not follow all paths 😟

Use after free in astrometry/util/wcs-xy2rd.c

stellarsolver/stellarsolver/astrometry/util/wcs-xy2rd.c

Line 144 in e0aa8d3

xylist_close(xyls);

xyls and rdls are freed twice in that function, via rdlist_closeand xylist_close going through bailout:.

Is it necessary to use the included versions of sep and astrometry.net?

Fedora has a (soft?) requirement that packages don't bundle other packages when they could be using a shared lib instead. This has caused stellarsolver packaging to get blocked, and kstars is very outdated because of it.

https://bugzilla.redhat.com/show_bug.cgi?id=1938451

I want to know if there is something special about these included libs or if it is fine to use the already packaged and up to date versions.

Resource leak in astrometry/blind/blind.c

stellarsolver/stellarsolver/astrometry/blind/blind.c

Lines 1392 to 1398 in e0aa8d3

 if (qfits_header_dump(hdr, fout)) { 

 logerr("Failed to write FITS WCS header.\n"); 

 return -1; 

 } 

 fits_pad_file(fout); 

 qfits_header_destroy(hdr); 

 fclose(fout);

hdr and fout are lost here.

commandline version - solve-field script

Thank you very much for this amazing piece of software.
I was wondering if it was possible to setup a command-line version that would act as a direct (but more efficient) replacement for solve-field script from astrometry.net ?

Thank you very much for the help.

Resource leak in astrometry/util/scamp-catalog.c

stellarsolver/stellarsolver/astrometry/util/scamp-catalog.c

Lines 72 to 75 in e0aa8d3

 if (qfits_header_write_line(hdr, i, hdrstring + i * FITS_LINESZ)) { 

 ERROR("Failed to get scamp catalog field header line %i", i); 

 return -1; 

 }

hdrstring, freehdr and hdr are lost here.

Run stellarsolver from terminal

options already set which works best for me. So I have a few questions for your program:

Is it possible to run stellar solver from the terminal, without GUI because I want to put it in a docker, and run it automatically on every new image in a folder?
If it is, how to set parameters (e.g. scale, initial position,...)?
I need an output with the position of every star from the field and from the catalog, so I can calculate on-sky separation between these two points, and call it the precision of solving. Also, can I output the .wcs file with a solution?
What about the distortion of a lens, how to check it, or set different tweak orders (astrometry.net option)?

These are all just a question I have because I am already using astrometry.net to solve all of it, but as I tried your software, it is much faster(under 2 sec, where astromety.net needs 4).

Build is not possible on Raspberry Pi 64 bit Bullseye

I get the following error when installing the prerequisites because I am asked to install obsolete software.

sudo apt -y install git cmake qt5-default libcfitsio-dev libgsl-dev wcslib-dev
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Package qt5-default is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'qt5-default' has no installation candidate
Paul

Get rid of more astrometry.net dependencies

Hi folks

This is not really a bug report, but more of a heads up :)
I actually did something very similar as you do here at:
https://github.com/mgreter/astrometrylib

I found your project a bit late in my attempt and since I IMHO got even a little bit
further at stripping down than you did here, I wanted to share some of my approaches.
Maybe you would like to take a peek at how I did the port 😉

In the end I only have 65 files from astrometry.net left in my tree (stellarsolver around 400?).
I also got completely rid of an-qfits and the bl.h lists. The former was of course the hardest, since
that meant I would need a different loader for the indexes. Instead of reinventing that wheel in C again,
I decided it would be easier to just convert the indexes to a more (fixed) binary format. This has of
course the drawback that the original indexes are not directly compatible, but this really got rid of
a lot of the complicated dependencies. And the new binary index loader is only ~250 lines and it
IMO really makes sense to have them very easily readable for this purpose.

I also added multi-threading to my POC in order to check that possibility. Other than that pretty much everything
else is hardcoded in my POC yet, although at the right places to implement something useful instead.

Hope you don't mind me opening this github issue.

Looking forward to your feedback!

Uninitialised read in sep/extract.cpp

stellarsolver/stellarsolver/sep/extract.cpp

Lines 269 to 271 in e0aa8d3

 stacksize = w + 1; 

 QMALLOC(info, infostruct, stacksize, status); 

 QCALLOC(store, infostruct, stacksize, status);

stellarsolver/stellarsolver/sep/extract.cpp

Line 610 in e0aa8d3

lutz->update(&info[co], &store[xl], pixel);

if luflag is true and some other conditions around line 570, info is used uninitialised here.

Resource leak in astrometry/util/sip_qfits.c

stellarsolver/stellarsolver/astrometry/util/sip_qfits.c

Lines 88 to 91 in e0aa8d3

 if (res) { 

 ERROR("Failed to write FITS header to file \"%s\"", fn); 

 return -1; 

 }

stellarsolver/stellarsolver/astrometry/util/sip_qfits.c

Lines 121 to 124 in e0aa8d3

 if (res) { 

 ERROR("Failed to write FITS header to file \"%s\"", fn); 

 return -1; 

 }

fid is lost here.

Resource leak in astrometry/util/fitstable.c

stellarsolver/stellarsolver/astrometry/util/fitstable.c

Lines 298 to 301 in e0aa8d3

 if (fitstable_read_row_data(intable, rows ? rows[i] : i, buf)) { 

 ERROR("Failed to read data from input table"); 

 return -1; 

 }

buf is lost here.

stellarsolver/stellarsolver/astrometry/util/fitstable.c

Lines 644 to 647 in e0aa8d3

 if (offset + N > bl_size(tab->rows)) { 

 ERROR("Number of data items requested exceeds number of rows: offset %i, n %i, nrows %zu", offset, N, bl_size(tab->rows)); 

 return -1; 

 }

dest and tempdata are lost here.

stellarsolver/stellarsolver/astrometry/util/fitstable.c

Lines 945 to 948 in e0aa8d3

 if (!tab->rows) { 

 ERROR("No data has been written to this fitstable"); 

 return NULL; 

 }

fitsdata and cdata are lost here.

stellarsolver/stellarsolver/astrometry/util/fitstable.c

Lines 975 to 979 in e0aa8d3

 if (res) { 

 ERROR("Failed to read column from FITS file"); 

 // MEMLEAK! 

 return NULL; 

 }

fitsdata and tempdata are lost here.

stellarsolver/stellarsolver/astrometry/util/fitstable.c

Lines 839 to 843 in e0aa8d3

 if (fseeko(table->fid, start + i * table->table->tab_w, SEEK_SET) || 

 fits_write_data_array(table->fid, src, col->fitstype, col->arraysize, flip)) { 

 SYSERROR("Failed to write row %i of column %i", rowoffset+i, colnum); 

 return -1; 

 }

buf and src are lost here.

stellarsolver/stellarsolver/astrometry/util/fitstable.c

Lines 1274 to 1281 in e0aa8d3

 if (fitstable_write_header(outtable)) { 

 ERROR("Failed to write output table header"); 

 return -1; 

 } 

 if (fitstable_copy_rows_data(intable, NULL, fitstable_nrows(intable), outtable)) { 

 ERROR("Failed to copy rows from input table to output"); 

 return -1; 

 }

outtable is lost here.

Uninitialised value in parameters.cpp

stellarsolver/stellarsolver/parameters.cpp

Line 181 in e0aa8d3

return params;

Field inflags is left uninitialised here.

SIGFPE on i386

Capturing a single frame in Focus:

Thread 22 "SextractorSolve" received signal SIGFPE, Arithmetic exception.
[Switching to Thread 0xa1d7fb40 (LWP 2531)]
0xb518c6db in InternalSextractorSolver::runSEPSextractor (this=0xae178e20)
    at /var/jenkins_home/workspace/kstars-ci_i386-stellarsolver/stellarsolver/internalsextractorsolver.cpp:252
252	/var/jenkins_home/workspace/kstars-ci_i386-stellarsolver/stellarsolver/internalsextractorsolver.cpp: No such file or directory.
(gdb) bt
#0  0xb518c6db in InternalSextractorSolver::runSEPSextractor() (this=0xae178e20)
    at /var/jenkins_home/workspace/kstars-ci_i386-stellarsolver/stellarsolver/internalsextractorsolver.cpp:252
#1  0xb518e63e in InternalSextractorSolver::extract() (this=0xae178e20)
    at /var/jenkins_home/workspace/kstars-ci_i386-stellarsolver/stellarsolver/internalsextractorsolver.cpp:99
#2  0xb518e63e in InternalSextractorSolver::run() (this=<optimized out>)
    at /var/jenkins_home/workspace/kstars-ci_i386-stellarsolver/stellarsolver/internalsextractorsolver.cpp:141
#3  0xb581fdcc in  () at /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#4  0xb52a43bd in start_thread (arg=0xa1d7fb40) at pthread_create.c:463
#5  0xb483bfe6 in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:108

This is an Atom i386 cpu with 1GB.

astrometry.log prints double values incorrectly on ARM 32bit

Whenever a double precision value is written to the log a crazy number is printed.
Affects users of Kstars on 32bit ARM like astroberry
It can be resolved by sprintf into a string followed by printf of the string but I imagine there is a compiler/linker option that might resolve it.
Not sure if it has any other flow on effect. Solving seems to work ok although I came across this helping another user whowas experiencing intermittent crashes when solving. The same values in the Kstars log look ok.
When astroberry is upgraded to 64 bit the issue should disappear.
I do recall a similar issue with the Avalon driver where printf of a double value requires the format to be %lf instead of %f to avoid a crash on RPi.
Google search shows a history of this issue or similar but no clear resolution and lots of red herrings.
I was able to reporduce the issue on Ubuntu 20.04 32 bit on RPi3 and with Ubuntu 20.04 64bit the log values print correctly
astrometrylog.txt

An issue with plate solve

Hello!
I have posted a message on EKOS forum on indilib.org describing my problems with plate solving. I am not sure if you (the authors) read the forum, so decided to create an issue here.

Basically, the problem is that while in many cases StellarSolver solves images just fine, there are cases where it fails and I do not see explanation.

Lets take the attached Rosette Nebula image, when I resolve the image it fails:

Automatically downsampling the image by 3
Evaluating Installed RAM for inParallel Option. Total Size of Index files: 1.96174 GB, Installed RAM: 62.7147 GB, Free RAM: 5.21823 GB
There should be enough RAM to load the indexes in parallel.
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Sextractor with the 1-Default profile . . .
Stars Found before Filtering: 509
Stars Found after Filtering: 509
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Configuring StellarSolver
Scale range: 13.3125 to 16.2709 arcsec/pixel
Downsampling is multiplying the pixel scale by: 3
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Solver was aborted, timed out, or failed, so no solution was found
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Internal Extractor w/ StellarSolver failed after 591.048 second(s).
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Interestingly, when I un-check "Use Scale" (which by default is set to Low: 4.43751 and High: 5.42363) it gets solved immediately. I suspect that when I use KStars/EKOS to plate solve, it sets the Scale values and it is causing the issue, I have unchecked the scale options in EKOS settings but this does not make any difference:

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Automatically downsampling the image by 3
Evaluating Installed RAM for inParallel Option. Total Size of Index files: 1.96174 GB, Installed RAM: 62.7147 GB, Free RAM: 21.3926 GB
There should be enough RAM to load the indexes in parallel.
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Sextractor with the 1-Default profile . . .
Stars Found before Filtering: 508
Stars Found after Filtering: 508
Starting 24 threads to solve on multiple scales
Solver # 1, Low 0.1, High 0.412326 arcsecperpix
Solver # 2, Low 0.412326, High 1.34931 arcsecperpix
Solver # 3, Low 1.34931, High 2.91094 arcsecperpix
Solver # 4, Low 2.91094, High 5.09722 arcsecperpix
Solver # 5, Low 5.09722, High 7.90816 arcsecperpix
Solver # 6, Low 7.90816, High 11.3438 arcsecperpix
Solver # 7, Low 11.3438, High 15.404 arcsecperpix
Solver # 8, Low 15.404, High 20.0889 arcsecperpix
Solver # 9, Low 20.0889, High 25.3984 arcsecperpix
Solver # 10, Low 25.3984, High 31.3326 arcsecperpix
Solver # 11, Low 31.3326, High 37.8915 arcsecperpix
Solver # 12, Low 37.8915, High 45.075 arcsecperpix
Solver # 13, Low 45.075, High 52.8832 arcsecperpix
Solver # 14, Low 52.8832, High 61.316 arcsecperpix
Solver # 15, Low 61.316, High 70.3734 arcsecperpix
Solver # 16, Low 70.3734, High 80.0556 arcsecperpix
Solver # 17, Low 80.0556, High 90.3623 arcsecperpix
Solver # 18, Low 90.3623, High 101.294 arcsecperpix
Solver # 19, Low 101.294, High 112.85 arcsecperpix
Solver # 20, Low 112.85, High 125.031 arcsecperpix
Solver # 21, Low 125.031, High 137.836 arcsecperpix
Solver # 22, Low 137.836, High 151.266 arcsecperpix
Solver # 23, Low 151.266, High 165.321 arcsecperpix
Solver # 24, Low 165.321, High 180 arcsecperpix
Scale range: 0.1 to 0.412326 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 0.218447 to 0.900713
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 15.404 to 20.0889 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 33.6495 to 43.8835
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 45.075 to 52.8832 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 98.4648 to 115.521
Scale range: 52.8832 to 61.316 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 115.521 to 133.943
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 112.85 to 125.031 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 246.517 to 273.125
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 101.294 to 112.85 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 221.273 to 246.517
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 25.3984 to 31.3326 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 55.482 to 68.4451
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 151.266 to 165.321 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 330.435 to 361.137
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 125.031 to 137.836 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 273.125 to 301.098
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 137.836 to 151.266 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 301.098 to 330.435
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 1.34931 to 2.91094 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 2.94751 to 6.35884
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 20.0889 to 25.3984 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 43.8835 to 55.482
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 61.316 to 70.3734 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 133.943 to 153.728
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 11.3438 to 15.404 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 24.78 to 33.6495
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 165.321 to 180 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 361.137 to 393.204
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 2.91094 to 5.09722 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 6.35884 to 11.1347
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 7.90816 to 11.3438 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 17.2751 to 24.78
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 5.09722 to 7.90816 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 11.1347 to 17.2751
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 37.8915 to 45.075 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 82.7727 to 98.4648
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 70.3734 to 80.0556 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 153.728 to 174.879
Scale range: 0.412326 to 1.34931 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 0.900713 to 2.94751
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 80.0556 to 90.3623 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 174.879 to 197.393
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 90.3623 to 101.294 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 197.393 to 221.273
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
Scale range: 31.3326 to 37.8915 degrees wide
Image width: 4944 pixels, Downsampled Image width: 1648 pixels; arcsec per pixel range: 68.4451 to 82.7727
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Starting Internal StellarSolver Astrometry.net based Engine with the 1-Default profile. . .
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Solve Log Odds: 155.568
Number of Matches: 22
Solved with index: 4111
Field center: (RA,Dec) = (97.9495, 4.9492) deg.
Field center: (RA H:M:S, Dec D:M:S) = (06:31:47.870, +04:56:57.124).
Field is: (-14.7958, -9.18354) deg from search coords.
Field size: 3.05834 x 2.03064 degrees
Pixel Scale: 2.22755"
Field rotation angle: up is 78.6137 degrees E of N
Field parity: neg

You can find more test images (which fail and succeed), including the Rosetta one, here: https://drive.google.com/drive/folders/1S7Mn9SVHWSAEA8Cn5O0KCPFPdfGlnJaQ?usp=sharing

Rosetta_Light_300_secs_2020-12-04T23-27-54_001.zip

Resource leak in externalsextractorsolver.cpp

stellarsolver/stellarsolver/externalsextractorsolver.cpp

Lines 1291 to 1296 in e0aa8d3

 if(fits_create_tbl(new_fptr, BINARY_TBL, nrows, tfields, 

 ttype, tform, tunit, extfile, &status)) 

 { 

 emit logOutput(QString("Could not create binary table.")); 

 return status; 

 }

stellarsolver/stellarsolver/externalsextractorsolver.cpp

Lines 1302 to 1306 in e0aa8d3

 if(fits_write_col(new_fptr, TFLOAT, column, firstrow, firstelem, nrows, xArray, &status)) 

 { 

 emit logOutput(QString("Could not write x pixels in binary table.")); 

 return status; 

 }

xArray, magArray and yArray are lost here.

Resource leak in astrometry/util/fitsioutils.c

stellarsolver/stellarsolver/astrometry/util/fitsioutils.c

Lines 253 to 257 in e0aa8d3

 if (fits_pad_file(fid) || 

 fclose(fid)) { 

 SYSERROR("Failed to pad or close file \"%s\"", fn); 

 return -1; 

 }

fits_pad_file and fits_pad_file_with are not closing fid, thus leaking that on success.

Resource leak in astrometry/util/fitsioutils.c

stellarsolver/stellarsolver/astrometry/util/fitsioutils.c

Lines 1154 to 1187 in e0aa8d3

 int fits_find_table_column(const char* fn, const char* colname, off_t* pstart, off_t* psize, int* pext) { 

 int i, nextens; 

 anqfits_t* fits; 

 fits = anqfits_open(fn); 

 if (!fits) { 

 ERROR("Failed to open file \"%s\"", fn); 

 return -1; 

 } 

 nextens = anqfits_n_ext(fits); 

 for (i=1; i<nextens; i++) { 

 const qfits_table* table; 

 int c; 

 table = anqfits_get_table_const(fits, i); 

 if (!table) { 

 ERROR("Couldn't read FITS table from file %s, extension %i.\n", fn, i); 

 continue; 

 } 

 c = fits_find_column(table, colname); 

 if (c == -1) { 

 continue; 

 } 

 if (anqfits_get_data_start_and_size(fits, i, pstart, psize)) { 

 ERROR("error getting start/size for ext %i in file %s.\n", i, fn); 

 return -1; 

 } 

 if (pext) *pext = i; 

 return 0; 

 } 

 debug("searched %i extensions in file %s but didn't find a table with a column \"%s\".\n", 

 nextens, fn, colname); 

 return -1; 

 }

fits is lost here (two returns).

Double free in astrometry/util/multiindex.c

stellarsolver/stellarsolver/astrometry/util/multiindex.c

Lines 140 to 148 in e0aa8d3

 if (quads) { 

 quadfile_close(quads); 

 } 

 if (codes) { 

 codetree_close(codes); 

 } 

 if (fits) { 

 anqfits_close(fits); 

 }

quads and fits are freed twice here. codes is not used, its free branch is dead code.

The large image can match the target. Why not the small image?

for example, in this diagram

Looking forward to your reply and help.

StellarSolver for Android?

Hi @rlancaste

This is not an issue, just a question.

What do you think, is it possible to build this library for Android platform using the Android NDK?

BR,

Ladislav

Resource leak in astrometry/util/fitsioutils.c

stellarsolver/stellarsolver/astrometry/util/fitsioutils.c

Lines 1137 to 1140 in e0aa8d3

 if (size == -1) { 

 ERROR("Failed to get data size for ext %i", i); 

 return NULL; 

 }

fits is lost here.

Uninitialised value in sep/extract.cpp

stellarsolver/stellarsolver/sep/extract.cpp

Lines 632 to 635 in e0aa8d3

 else if (newmarker == 'F') 

 { 

 ps = psstack[--pstop]; 

 if ((cs == NONOBJECT) && (ps == COMPLETE))

There is a code path that uses psstack without initialising it after allocation. That initialisation should probably be done around line 317.

Resource leak in astrometry/util/qidxfile.c

stellarsolver/stellarsolver/astrometry/util/qidxfile.c

Line 43 in e0aa8d3

qf = calloc(1, sizeof(qidxfile));

stellarsolver/stellarsolver/astrometry/util/qidxfile.c

Lines 56 to 59 in e0aa8d3

 if (!qf->fb) { 

 ERROR("Failed to create fitsbin"); 

 return NULL; 

 }

qf is lost here.

astrometry.net address hardcoded, impossible to use a local running nova server

Hi,
looking here: https://github.com/rlancaste/stellarsolver/blob/master/stellarsolver/onlinesolver.cpp#L325
It seems the software is using a hardcoded value of nova.astrometry.net in place of the specified server (eg. from ekos config).
This makes it impossible to use a local copy of nova.

Resource leak in astrometry/util/starkd.c

stellarsolver/stellarsolver/astrometry/util/starkd.c

Lines 559 to 562 in e0aa8d3

 if (kdtree_fits_append_tree_to(s->tree, s->header, fid)) { 

 ERROR("Failed to write star kdtree"); 

 return -1; 

 }

io is lost here.

Resource leak in astrometry/util/starkd.c

stellarsolver/stellarsolver/astrometry/util/starkd.c

Line 408 in e0aa8d3

counts = calloc(Ndata(s), sizeof(uint8_t));

stellarsolver/stellarsolver/astrometry/util/starkd.c

Line 417 in e0aa8d3

return 0;

counts is lost here.

Resource leak in astrometry/libkd/kdtree_internal.c

stellarsolver/stellarsolver/astrometry/libkd/kdtree_internal.c

Lines 2411 to 2415 in e0aa8d3

 if (kdtree_qsort(data, kd->perm, left, right, D, dim)) { 

 ERROR("kdtree_qsort failed"); 

 // FIXME: memleak mania! 

 return NULL; 

 }

Resource leak confirmed by Coverity.

Resource leak in sep/extract.cpp

stellarsolver/stellarsolver/sep/extract.cpp

Lines 355 to 359 in e0aa8d3

 if (conv) 

 { 

 /* allocate memory for convolved buffers */ 

 QMALLOC(cdscan, PIXTYPE, stacksize, status); 

 if (filter_type == SEP_FILTER_MATCHED)

stellarsolver/stellarsolver/sep/extract.cpp

Line 752 in e0aa8d3

return status;

If conv is true, cdscan leaks here.

Resource leak in astrometry/qfits-an/anqfits.c

stellarsolver/stellarsolver/astrometry/qfits-an/anqfits.c

Lines 546 to 557 in e0aa8d3

 fid = fopen(qf->filename, "rb"); 

 if (!fid) { 

 return NULL; 

 } 

 data = malloc(N + 1); 

 if (start) { 

 if (fseeko(fid, start, SEEK_SET)) { 

 SYSERROR("Failed to seek to start of FITS header: byte %li in %s", 

 (long int)start, qf->filename); 

 return NULL; 

 } 

 }

fid is lost here.

Readme instructions to download and run stellar solver incorrect?

Hi,

I'm having trouble getting StellerSolver even running with MacOS. The readme.md says to get a recent dmg, but there appears to be none for StellarSolver in github... I guess this means KStars?

After using craft to install stellarsolver, there's no description on how to get it started or run it. Does it run from inside KStars or a different app? How do I get the gui I'm seeing in the readme to appear?

Sorry for the newb questions, but I've been hunting on how to do this for the weekend with no luck.

	buf_out = qfits_malloc(npix * BYTESPERPIXEL(ptype));
	op = buf_out;

	ct = fits_get_dupstring(hdr, "CTYPE1");
	if ((ct && streq(ct, "RA---TPV")) \|\| forcetan) {
	// http://iraf.noao.edu/projects/ccdmosaic/tpv.html
	logmsg("Replacing CTYPE1 = %s header with RA---TAN\n", ct);
	fits_update_value(hdr, "CTYPE1", "RA---TAN");
	}
	ct = fits_get_dupstring(hdr, "CTYPE2");
	if ((ct && streq(ct, "DEC--TPV")) \|\| forcetan) {
	logmsg("Replacing CTYPE2 = %s header with DEC--TAN\n", ct);
	fits_update_value(hdr, "CTYPE2", "DEC--TAN");
	}

	if (!pl_size(engine->indexes))
	{
	emit logOutput(QString("\n\n"
	"---------------------------------------------------------------------\n"
	"You must include at least one index file in the index file directories\n\n"
	"See http://astrometry.net/use.html about how to get some index files.\n"
	"---------------------------------------------------------------------\n"
	"\n"));
	return -1;
	}

	scamp = scamp_catalog_open_for_writing(filename, FALSE);
	if (!scamp) {
	return -1;
	}

	if (scamp_catalog_write_field_header(scamp, hdr)) {
	return -1;
	}

	if (!vf->fieldcopy \|\| !vf->xy) {
	fprintf(stderr, "Failed to copy the field.\n");
	return NULL;
	}

	if (!qf->fb) {
	ERROR("Failed to create fitsbin");
	return NULL;
	}

	if ((fwrite(vals, 1, N, f) != N) \|\|
	fclose(f)) {
	SYSERROR("Failed to write solved file \"%s\"", fn);
	return -1;
	}

	if (det == 0.0) {
	fprintf(stderr, "ERROR (fit_transform) -- determinant zero\n");
	return;
	}

	if (fits) {
	io = kdtree_fits_open_fits(fits);
	fn = fits->filename;
	} else
	io = kdtree_fits_open(fn);

	if (qfits_header_dump(hdr, fout)) {
	logerr("Failed to write FITS WCS header.\n");
	return -1;
	}
	fits_pad_file(fout);
	qfits_header_destroy(hdr);
	fclose(fout);

	if (qfits_header_write_line(hdr, i, hdrstring + i * FITS_LINESZ)) {
	ERROR("Failed to get scamp catalog field header line %i", i);
	return -1;
	}

	stacksize = w + 1;
	QMALLOC(info, infostruct, stacksize, status);
	QCALLOC(store, infostruct, stacksize, status);

	if (res) {
	ERROR("Failed to write FITS header to file \"%s\"", fn);
	return -1;
	}

	if (fitstable_read_row_data(intable, rows ? rows[i] : i, buf)) {
	ERROR("Failed to read data from input table");
	return -1;
	}

	if (offset + N > bl_size(tab->rows)) {
	ERROR("Number of data items requested exceeds number of rows: offset %i, n %i, nrows %zu", offset, N, bl_size(tab->rows));
	return -1;
	}

	if (!tab->rows) {
	ERROR("No data has been written to this fitstable");
	return NULL;
	}

	if (res) {
	ERROR("Failed to read column from FITS file");
	// MEMLEAK!
	return NULL;
	}

	if (fseeko(table->fid, start + i * table->table->tab_w, SEEK_SET) \|\|
	fits_write_data_array(table->fid, src, col->fitstype, col->arraysize, flip)) {
	SYSERROR("Failed to write row %i of column %i", rowoffset+i, colnum);
	return -1;
	}

	if (fitstable_write_header(outtable)) {
	ERROR("Failed to write output table header");
	return -1;
	}
	if (fitstable_copy_rows_data(intable, NULL, fitstable_nrows(intable), outtable)) {
	ERROR("Failed to copy rows from input table to output");
	return -1;
	}

	if(fits_create_tbl(new_fptr, BINARY_TBL, nrows, tfields,
	ttype, tform, tunit, extfile, &status))
	{
	emit logOutput(QString("Could not create binary table."));
	return status;
	}

rlancaste / stellarsolver Goto Github PK

stellarsolver's People

Contributors

Stargazers

Watchers

Forkers

stellarsolver's Issues

Recommend Projects

Recommend Topics

Recommend Org

	if(fits_write_col(new_fptr, TFLOAT, column, firstrow, firstelem, nrows, xArray, &status))
	{
	emit logOutput(QString("Could not write x pixels in binary table."));
	return status;
	}

	if (fits_pad_file(fid) \|\|
	fclose(fid)) {
	SYSERROR("Failed to pad or close file \"%s\"", fn);
	return -1;
	}

	int fits_find_table_column(const char* fn, const char* colname, off_t* pstart, off_t* psize, int* pext) {
	int i, nextens;

	anqfits_t* fits;
	fits = anqfits_open(fn);
	if (!fits) {
	ERROR("Failed to open file \"%s\"", fn);
	return -1;
	}

	nextens = anqfits_n_ext(fits);
	for (i=1; i<nextens; i++) {
	const qfits_table* table;
	int c;
	table = anqfits_get_table_const(fits, i);
	if (!table) {
	ERROR("Couldn't read FITS table from file %s, extension %i.\n", fn, i);
	continue;
	}
	c = fits_find_column(table, colname);
	if (c == -1) {
	continue;
	}
	if (anqfits_get_data_start_and_size(fits, i, pstart, psize)) {
	ERROR("error getting start/size for ext %i in file %s.\n", i, fn);
	return -1;
	}
	if (pext) *pext = i;
	return 0;
	}
	debug("searched %i extensions in file %s but didn't find a table with a column \"%s\".\n",
	nextens, fn, colname);
	return -1;
	}

	if (quads) {
	quadfile_close(quads);
	}
	if (codes) {
	codetree_close(codes);
	}
	if (fits) {
	anqfits_close(fits);
	}

	if (size == -1) {
	ERROR("Failed to get data size for ext %i", i);
	return NULL;
	}

	else if (newmarker == 'F')
	{
	ps = psstack[--pstop];
	if ((cs == NONOBJECT) && (ps == COMPLETE))

	if (kdtree_fits_append_tree_to(s->tree, s->header, fid)) {
	ERROR("Failed to write star kdtree");
	return -1;
	}

	if (kdtree_qsort(data, kd->perm, left, right, D, dim)) {
	ERROR("kdtree_qsort failed");
	// FIXME: memleak mania!
	return NULL;
	}

	if (conv)
	{
	/* allocate memory for convolved buffers */
	QMALLOC(cdscan, PIXTYPE, stacksize, status);
	if (filter_type == SEP_FILTER_MATCHED)

	fid = fopen(qf->filename, "rb");
	if (!fid) {
	return NULL;
	}
	data = malloc(N + 1);
	if (start) {
	if (fseeko(fid, start, SEEK_SET)) {
	SYSERROR("Failed to seek to start of FITS header: byte %li in %s",
	(long int)start, qf->filename);
	return NULL;
	}
	}