Unable to build LZVN on apple m1 about afsctool HOT 15 OPEN

I believe this is fixed, I was able to make this on my m1 mbp by default.

from afsctool.

from afsctool.

I do see the same when using a brew-installed afsctool. However, after compiling myself, it works fine.

$ uname -a
Darwin zach-mbp.lan 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64

Did you fetch the submodule, either cloning with git clone --recurse-submodules or running something like git submodule update --init --recursive?

from afsctool.

Looks like you'll need #59, the git:// protocol isn't allowed on github anymore.

from afsctool.

No, there's no need to be configured with ssh, I think @kapitainsky was confusing the git protocol git://github.com/... with the ssh protocol [email protected]:... (which is easy to do, they both start with the prefix git).

from afsctool.

There's support for running Intel binaries, no? Have you tried if that works for afsctool?

Yes there is through Rosetta 2. I can successfully build the LZVN binary with make only in the root directroy but then the header files (LZVN_HEADER,LIB: LZVN_HEADER-NOTFOUND LZVN_LIBRARY) are still missing.

from afsctool.

LZVN contains assembly, which is X86 specific

Is this the same for LZFSE?

I notice that the brew version of afsctool 1.7.2 contains neither.

I just got an M1 MBP.

from afsctool.

Fingers crossed the next brew version will also include the capability.

from afsctool.

I believe this is fixed, I was able to make this on my m1 mbp by default.

Having seen no changes to include LZVN or LZFSE in afsctool 1.7.3 recently installed via brew...

...I just tried making the latest code on mac M1 Mac.

Indeed, make completes successfully, but the resulting binary is missing both LZVN and LZFSE?

@Dr-Emann do you see differently than below?

$ afsctool -T LZVN
Sorry, LZVN compression has not been enabled in this build.
$ afsctool -T LZFSE
Sorry, LZFSE compression has not been enabled in this build.

from afsctool.

Trying again from fresh files, I see the issue.

❯ git clone --recurse-submodules https://github.com/RJVB/afsctool.git
Cloning into 'afsctool'...
remote: Enumerating objects: 974, done.
remote: Counting objects: 100% (82/82), done.
remote: Compressing objects: 100% (42/42), done.
remote: Total 974 (delta 46), reused 65 (delta 40), pack-reused 892
Receiving objects: 100% (974/974), 511.27 KiB | 2.63 MiB/s, done.
Resolving deltas: 100% (653/653), done.
Submodule 'src/private/lzfse' (git://github.com/lzfse/lzfse) registered for path 'src/private/lzfse'
Cloning into '/Users/matt/Downloads/2022-11-11/afsctool/src/private/lzfse'...
fatal: unable to connect to github.com:
github.com[0: 140.82.121.4]: errno=Operation timed out

I will have to try again later.

from afsctool.

Submodule 'src/private/lzfse' (git://github.com/lzfse/lzfse) registered for path 'src/private/lzfse'

sub-modules use git not https - you need ssh to github configured.

or

cd afsctool/src/private
git clone https://github.com/lzfse/lzfse

and all will be fine

from afsctool.

Continued thanks!

from afsctool.

Done! And working.

Thanks again, all.

from afsctool.

from afsctool.

@RJVB The only other thing would be that it'd be nice to be able to enable LZVN/LZFSE in the brew builds. It seems like the simplest way would be to configure it to use git directly, rather than the auto-generated source tarball like this, (it seems homebrew will automatically fetch submodules when sourcing from git). The alternative would be to create a release tarball manually which includes the lzfse submodule? Or I do see there's a brew recipe for lzfse, it might be possible to dynamically link with it in the brew case?

from afsctool.