Comments (5)
RJVB
commented on July 21, 2024
That doesn't really surprise me. Does the x86_64 build run on that architecture as Apple claim it should? If so please use that for the time being.
Or adapt the code yourself. The code already uses a stripped-down version of CritSectEx.{h,cpp} so the build probably fails on code that isn't used at all. I do have a standalone version of the CritSectEx library which I'd like to keep in sync (as easily as possible). So rather than stripping out offending (and unused code) I'd appreciate if you could exclude it from building by putting #ifdef/#endifs around it. Don't worry about the token (could be the M1 equivalent of x86_64 of course); this is mostly to be certain I don't miss anything. I'll come in afterwards and use a proper filter to exclude x86 code on other platforms.
from afsctool.
RJVB
commented on July 21, 2024
Can you pull and try again please. Hopefully the fix was easier than I thought.
from afsctool.
malthe
commented on July 21, 2024
I get the following compiler output:
~/co/afsctool/build$ make
Scanning dependencies of target PP
[ 9%] Building CXX object CMakeFiles/PP.dir/src/utils.cpp.o
[ 18%] Building CXX object CMakeFiles/PP.dir/src/ParallelProcess.cpp.o
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
In file included from /Users/mborch/co/afsctool/src/Thread/Thread.hpp:14:
In file included from /Users/mborch/co/afsctool/src/CritSectEx/CritSectEx.h:43:
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:697:8: error: use of undeclared identifier '_InterlockedIncrement'
if( !_InterlockedIncrement(atomic) ){
^
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:698:4: error: use of undeclared identifier 'YieldProcessor'; did you mean
'FileProcessor'?
YieldProcessor();
^
/Users/mborch/co/afsctool/src/fsctool.h:98:7: note: 'FileProcessor' declared here
class FileProcessor;
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
In file included from /Users/mborch/co/afsctool/src/Thread/Thread.hpp:14:
In file included from /Users/mborch/co/afsctool/src/CritSectEx/CritSectEx.h:43:
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:711:8: error: use of undeclared identifier '_InterlockedDecrement'; did you
mean '_InterlockedSetTrue'?
if( _InterlockedDecrement(atomic) ){
^~~~~~~~~~~~~~~~~~~~~
_InterlockedSetTrue
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:694:20: note: '_InterlockedSetTrue' declared here
static inline void _InterlockedSetTrue( volatile long *atomic )
^
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:711:8: error: value of type 'void' is not contextually convertible to 'bool'
if( _InterlockedDecrement(atomic) ){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:712:5: error: use of undeclared identifier 'YieldProcessor'; did you mean
'FileProcessor'?
YieldProcessor();
^
/Users/mborch/co/afsctool/src/fsctool.h:98:7: note: 'FileProcessor' declared here
class FileProcessor;
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
In file included from /Users/mborch/co/afsctool/src/Thread/Thread.hpp:14:
In file included from /Users/mborch/co/afsctool/src/CritSectEx/CritSectEx.h:43:
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:716:8: error: use of undeclared identifier '_InterlockedIncrement'
if( _InterlockedIncrement(atomic) ){
^
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:717:5: error: use of undeclared identifier 'YieldProcessor'; did you mean
'FileProcessor'?
YieldProcessor();
^
/Users/mborch/co/afsctool/src/fsctool.h:98:7: note: 'FileProcessor' declared here
class FileProcessor;
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
/Users/mborch/co/afsctool/src/Thread/Thread.hpp:384:6: error: no matching function for call to '_InterlockedSetTrue'
_InterlockedSetTrue(isNotified);
^~~~~~~~~~~~~~~~~~~
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:694:20: note: candidate function not viable: no known conversion from 'long'
to 'volatile long *' for 1st argument; take the address of the argument with &
static inline void _InterlockedSetTrue( volatile long *atomic )
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
/Users/mborch/co/afsctool/src/Thread/Thread.hpp:395:7: error: no matching function for call to '_InterlockedSetTrue'
_InterlockedSetTrue(isLocked);
^~~~~~~~~~~~~~~~~~~
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:694:20: note: candidate function not viable: no known conversion from 'long'
to 'volatile long *' for 1st argument; take the address of the argument with &
static inline void _InterlockedSetTrue( volatile long *atomic )
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
/Users/mborch/co/afsctool/src/Thread/Thread.hpp:401:9: error: no matching function for call to '_InterlockedSetTrue'
_InterlockedSetTrue(isLocked);
^~~~~~~~~~~~~~~~~~~
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:694:20: note: candidate function not viable: no known conversion from 'long'
to 'volatile long *' for 1st argument; take the address of the argument with &
static inline void _InterlockedSetTrue( volatile long *atomic )
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
/Users/mborch/co/afsctool/src/Thread/Thread.hpp:402:9: error: use of undeclared identifier 'YieldProcessor'; did you mean
'FileProcessor'?
YieldProcessor();
^
/Users/mborch/co/afsctool/src/fsctool.h:98:7: note: 'FileProcessor' declared here
class FileProcessor;
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
/Users/mborch/co/afsctool/src/Thread/Thread.hpp:412:7: error: no matching function for call to '_InterlockedSetFalse'
_InterlockedSetFalse(isLocked);
^~~~~~~~~~~~~~~~~~~~
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:707:20: note: candidate function not viable: no known conversion from 'long'
to 'volatile long *' for 1st argument; take the address of the argument with &
static inline void _InterlockedSetFalse( volatile long *atomic )
^
In file included from /Users/mborch/co/afsctool/src/ParallelProcess.cpp:20:
In file included from /Users/mborch/co/afsctool/src/ParallelProcess_p.hpp:19:
/Users/mborch/co/afsctool/src/Thread/Thread.hpp:414:7: error: no matching function for call to '_InterlockedSetFalse'
_InterlockedSetFalse(isNotified);
^~~~~~~~~~~~~~~~~~~~
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:707:20: note: candidate function not viable: no known conversion from 'long'
to 'volatile long *' for 1st argument; take the address of the argument with &
static inline void _InterlockedSetFalse( volatile long *atomic )
^
/Users/mborch/co/afsctool/src/ParallelProcess.cpp:395:4: error: use of undeclared identifier '_InterlockedIncrement'
_InterlockedIncrement(&PP->nProcessing);
^
/Users/mborch/co/afsctool/src/ParallelProcess.cpp:397:4: error: use of undeclared identifier '_InterlockedDecrement'; did you
mean '_InterlockedSetTrue'?
_InterlockedDecrement(&PP->nProcessing);
^~~~~~~~~~~~~~~~~~~~~
_InterlockedSetTrue
/Users/mborch/co/afsctool/src/CritSectEx/msemul.h:694:20: note: '_InterlockedSetTrue' declared here
static inline void _InterlockedSetTrue( volatile long *atomic )
^
/Users/mborch/co/afsctool/src/ParallelProcess.cpp:398:4: error: use of undeclared identifier '_InterlockedIncrement'
_InterlockedIncrement(&PP->nProcessed);
^
16 errors generated.
make[2]: *** [CMakeFiles/PP.dir/src/ParallelProcess.cpp.o] Error 1
make[1]: *** [CMakeFiles/PP.dir/all] Error 2
make: *** [all] Err
from afsctool.
RJVB
commented on July 21, 2024
Bummer, my bad.
Pull and try again, please? (There may be a link error on a _yield() function which is supposed to be a compiler intrinsic from what I understood).
from afsctool.
malthe
commented on July 21, 2024
Works – amazing work.
from afsctool.
Related Issues (20)
- Is this afsctool the clear successor to the original? Should the homebrew afsctool formula point here instead? HOT 4
- Does your afsctool support APFS? HOT 2
- Unable to build LZVN on apple m1 HOT 15
- building for macOS-x86_64 but attempting to link with file built for macOS-arm64 HOT 8
- About maintenance of the fork HOT 3
- Is this identical to 'brew install afsctool' or is that the original version? HOT 4
- Failed to build on M1 - Monterey 12.0.1 with Xcode 13.1 HOT 11
- Process stuck waiting HOT 12
- Are we ready for a new release? HOT 3
- Unable to build when the path to Xcode contains spaces HOT 3
- Build errors with GCC 5 HOT 9
- Recovering missing/deleted files HOT 4
- Time Machine risks? HOT 3
- Incorrect license HOT 4
- -t and -i options usage HOT 10
- afsctool breaks binaries, sometimes (HFS+) HOT 9
- Compress, decompress, compress results in lots of mismatch errors HOT 19
- compressing breaks app (workaround: restart mac) HOT 25
- Cannot build HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from afsctool.