rjpeterson / hanzisize Goto Github PK

cant use external resources

Manually changing version numbers in package.json as well as in manifest.json is annoying and error-prone. I would like it to be automated to increment on every "git push"

• find and remove unnecessary async calls
• reorganize function calling to optimize speed
• implement html element indexing so 2nd, 3rd, 4th resizings are faster
• scan dom on popup and language change, tag elements to change, change on newfontsize (removes repeated regex)

The popup should occasionally show a "hint" about using and/or setting hotkeys to activate resizing

https://developer.chrome.com/docs/extensions/reference/storage/#synchronous-response-to-storage-updates

by listening for changes to chrome storage using the background script and firing the content script when a change is detected, the duplicate code in chromeTools.js can possibly be culled.

Language select options are listed in the target language. A tooltip with the english translation on hover would be helpful.

Chrome extension manifest v3 won't allow loading external scripts. Basically the same problem as the Firefox webstore version.

The background script that enables resizing via hotkey is currently just copy-pasted code from other parts of the extension with unneeded parts commented out. It should be cleaned up and unneeded code removed.

Currently the only "website" for Hanzisize is the Chrome and Firefox webstores. So, we should create a basic Github Pages website to provide new users information on how to use the extension, new features & releases, etc. This also will help with promotion of the extension.

• Better photos
• Slideshow
• Large slide, single color with basic message
• Medium and Large Promo banners

suggestion from reddit:
'Sounds awesome! I cant look at it now but is there a possibility of forcing a specific font for the Chinese characters as well? I love Kai Ti (I think its called or something close to that)'

It should default to hidden and when clicked show extension info, donation links, etc.

Maybe there is something useful there?

Error content: Unchecked runtime.lastError: This page cannot be scripted due to an ExtensionsSettings policy.

Can be solved by checking "Allow access to search page results" in extension settings.
This needs to be communicated through the popup notification div.

The extension in its current state requires users to click the browser icon every time a new page is loaded. Users should be able to use a hotkey to make this process more convenient.

https://developer.chrome.com/docs/extensions/reference/commands/

Opera/Chrome

Just like chrome & webstore pages, the firefox version is blocked on mozilla pages so we should display an error if the user tries to hanzisize one of these pages.

Extension no longer adds "text-elem" and "language-elem" classes on browser action

In the following code, text inside the tag gets resized while the text between and does not.

<span><a class="notranslate text-elem English-elem" href="/steapd_tea/" tabindex="0" style="--data-original-font-size:14px; font-size: 21px !important; line-height: normal !important;">@steapd_tea</a> hmm that's fascinating! 🙏might have to try some now😁</span>

• Firefox
• Opera
• Edge (still need to write tests)
• Safari

From /r/hebrew

זײַט אַזוי גוט קאָריגיר מיך
etalasi
2 minutes ago
I don't have a Github account to report an issue, but your regex expression for the Hebrew script in line 19 of contentScript.js covers only the Unicode block named "Hebrew" from U-0590 to U-05FF
ְֱֲֳִֵֶַָֹֺֻּֽ֑֖֛֢֣֤֥֦֧֪֚֭֮֒֓֔֕֗֘֙֜֝֞֟֠֡֨֩֫֬֯־ֿ׀ׁׂ׃ׅׄ׆ׇאבגדהוזחטיךכלםמןנסעףפץצקרשתׯװױײ׳״
and doesn't include the Hebrew letters in Alphabetic Presentation Forms (PDF) from U-FB1D to U-FB4F.
יִﬞײַﬠﬡﬢﬣﬤﬥﬦﬧﬨ﬩שׁשׂשּׁשּׂאַאָאּבּגּדּהּוּזּטּיּךּכּלּמּנּסּףּפּצּקּרּשּתּוֹבֿכֿפֿﭏ
I generated the strings of characters from each Unicode block with https://r12a.github.io/uniview, in case that helps you for testing.

(or at least make them do the same thing with separate selectbox entries)

Resizing Japanese skips over any element nodes that are only Kanji with no katakana or hiragana. This is bad because Kanji are the most complex and the most necessary to resize.

Update colors, simplify interface using slider for font size, change "more info" button, left/right arrow or typing for language changing, maybe hide language most of the time?

Current popup function is to initialize to "loading..." and then load interface after response is received from injected content script.

This works OK but results in significant delay when content script injects slowly like on Edge browser.

Instead, we should load basic interface first and allow user to input values immediately even if content script is not injected yet.
If script injects successfully, send content object. If not, display error.

• Remove slider entirely but leave input box for custom inputs

• Hangul (Korean)
• Thai
• Arabic
• Hebrew
• Hindi
• Latin-based(relabel English)
• Georgian
• Burmese

Text copied from clipboard are pasted on html page but extension doesn't work.

Firefox extensions aren't allowed to contain remote scripts.
create-react-app build process uses workbox to create a service worker and injects a remote script in the process

• Make dashes larger
• Color