risksense / flyway Goto Github PK

What version of Flyway are you using?

release-4.0.3-mongodb

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)

Java API

What database are you using (type & version)?

MongoDB 3.3

What operating system are you using?

OSX El Capitan

What did you do?

(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
Run the info() and the migrate() commands on MongoFlyway.

What did you expect to see?

info and migrate

What did you see instead?

So the internal mongoclient closes its connection after any single command. So running info and migrate are two commands and that won't work. An external mongoclient will work. However when setting a mongoclient into MongoFlyway, you do not capture a databaseName. Therefore, when constructing the MongoMetaDataTable, an NPE is thrown and migration fails. Our workaround is to add an overloaded setMongoClient that adds a databaseName as a second argument.

What version of Flyway are you using?

release-4.0.3-mongodb

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)

Java API

What database are you using (type & version)?

MongoDB 3.3

What operating system are you using?

OSX El Capitan

What did you do?

(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
execute mongoFlyway.migrate on server where db is not yet created

What did you expect to see?

migration work

What did you see instead?

We have a microservice architecture in which each microservice uses a mongo client on behalf of a user with only readWrite privileges. When a db is not yet created, or also in the case where it is created but the schema_version collection is not yet created, a listDatabases method is called which is not available for a regular user. This throws a FlywayException and migration dies. Our workaround is to catch the exception on listDatabases and then make a call to find the schema_version collection.

Hello Ristsense,

Thanks for your work to support mongo. I found your code haven't merge to official version. Is any plan to do that?

What version of Flyway are you using?

release-4.0.3-mongodb

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)

Java API

What database are you using (type & version)?

MongoDB 3.3

What operating system are you using?

OSX El Capitan

What did you do?

(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
Try to configure a callback with the flyway.callbacks property.

What did you expect to see?

A callback executed

What did you see instead?

ClassUtils.instantiate throws a NoSuchMethod exception.

The Callback interface is not public. The abstract MongoFlywayCallback class defines a one-arg method. The ClassUtils that is used to instantiate a configured callback uses Class.forName to instantiate, and that only works with zero-arg constructors. We cannot extend MongoFlywayCallback and add a zero-arg constructor.

Our workaround is to manually set a callback into MongoFlyway, but this is a limited-value solution.