Giter Club home page Giter Club logo

Comments (7)

jim-wilson avatar jim-wilson commented on August 23, 2024

The assembler doesn't have typed constants. So 0x800 is 0x00000800 which is not valid for addi. RV32i has 32-bit constants, so 0xFFFFF800 is valid, and so is 0sFFFFFFFF FFFFF800. RV64i has 64-bit constants, so 0x00000000fffff800 is not valid, and 0xFFFFFFFF FFFFF800 is valid.

Another way to look at this is to try decimal constants. If someone writes "addi x0, x0, 4095" should we interpret that as "addi x0, x0, -1"? That would just be silly. Similarly, if someone writes "addi x0, x0, 0xfff" it would be wrong to treat that as -1 because 0xfff is 4095.

Another way to look at this is that humans tend to make mistakes when writing assembly language code, so we should not assume that something was intentional when it is ambiguous. 0x800 is ambiguous as it could be 2048 or -2048, so we don't accept it. 0xFFFFF800 is unambiguous for rv32i so we do accept it.

from riscv-asm-manual.

nick-knight avatar nick-knight commented on August 23, 2024

Another way to look at this is to try decimal constants. If someone writes "addi x0, x0, 4095" should we interpret that as "addi x0, x0, -1"? That would just be silly. Similarly, if someone writes "addi x0, x0, 0xfff" it would be wrong to treat that as -1 because 0xfff is 4095.

Well,

addi x0, x0, 4294965248

is interpreted as

addi x0, x0, -2048

on RV32I, and is illegal on RV64I. I think that's a bit silly too.

from riscv-asm-manual.

nick-knight avatar nick-knight commented on August 23, 2024

Perceived silliness aside, I'm not asking for any change in behavior. I'm just raising this issue to see if there is consensus around a case for documenting this behavior.

from riscv-asm-manual.

jim-wilson avatar jim-wilson commented on August 23, 2024

rv32 has 32-bit constants. So treating 4294965248 as -2048 is consistent with everything else.

from riscv-asm-manual.

Hsiangkai avatar Hsiangkai commented on August 23, 2024

llvm treat hexadecimal value as unsigned value. So, 0xfff is 4095 and 0xfffff800 is 4294965248. Both are out of range for addi.

from riscv-asm-manual.

nick-knight avatar nick-knight commented on August 23, 2024

I started a PR to address this then stumbled across what you just mentioned, that LLVM doesn't support this behavior. So my question really should have included, is GNU's behavior a language extension? Without an agreed-upon language spec, this is hard to answer.

from riscv-asm-manual.

jim-wilson avatar jim-wilson commented on August 23, 2024

You can document the subset that both GNU and LLVM toolchains accept.

from riscv-asm-manual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.