Giter Club home page Giter Club logo

opensource.ripple.com's Introduction

opensource.ripple.com's People

Contributors

adriacarrera avatar agustinmj avatar amarantha-k avatar dennisdawson avatar jst5000 avatar justinr1234 avatar maria-robobug avatar mduo13 avatar oeggert avatar platonicsocrates avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

opensource.ripple.com's Issues

Add AMMCreate Fee description

In an AMMCreate transaction, the Fee field must be an amount greater than or equal to one owner reserve, but there appears to be no mention of this.

Also in the AMMCreate transaction example, 10drop is specified, which should also be corrected.

Need individual page metadata in SEO/link unfurl friendly formats

If you link any page on xrpl.org from Slack, social media, or other sites, you'll likely get a link preview individualized to that page, for example:

Screenshot_20230508-094443_1

That's because Dactyl and the xrpl templates always populate various <meta> tags with details based on the page's title, "blurb", etc. Most of these can be set manually but it sets then to something reasonable if you don't (e.g. the blurb is based on the first paragraph).

The opensource site uses a generic description line for every page, for example:

Screenshot_20230508-094746_1

With Redocly, you have to manually specify various seo frontmatter fields on the page for it to provide an individualized result. So we should make sure every page has the appropriate fields set and maybe even set up CI to request that those fields are set on each page if we can.

More detailed README/contribution guidelines

  • How do you do preview builds?
  • Do production deploys happen automatically?
  • How is the repo structured?
  • What are the standards/requirements/code of conduct for contributing to this repo?

Missing $exrpd command in EVM Sidechain Devnet Documentation

Hello,

I was following the instructions on Join the EVM Sidechain Devnet page, and I noticed that there seems to be a missing step.

In the 'Pre-requisites' section, after creating an alias for exrpd, there's no instruction to actually run the $exrpd command. This could potentially lead to confusion for users who are not familiar with setting up aliases or using Docker.

Here is a suggestion for an additional step:

# Run exrpd
$ exrpd

And there is result when I run the $exrpd

Unable to find image 'peersyst/xrp-evm-blockchain:latest' locally
latest: Pulling from peersyst/xrp-evm-blockchain
f56be85fc22e: Pull complete
05aee0655c84: Pull complete
93746c630e3f: Pull complete
2a104fb99f3c: Pull complete
Digest: sha256:e081b783f5cf220496432694b9e5d909ae6e92fc37c2e104905ebaace886cb50
Status: Downloaded newer image for peersyst/xrp-evm-blockchain:latest
Ethermint Daemon

Usage:
  exrpd [command]

Available Commands:
  add-genesis-account Add a genesis account to genesis.json
  collect-gentxs      Collect genesis txs and output a genesis.json file
  config              Create or query an application CLI configuration file
  debug               Tool for helping with debugging your application
  export              Export state to JSON
  gentx               Generate a genesis tx carrying a self delegation
  help                Help about any command
  index-eth-tx        Index historical eth txs
  init                Initialize private validator, p2p, genesis, and application configuration files
  keys                Manage your application's keys
  migrate             Migrate genesis to a specified target version
  query               Querying subcommands
  rollback            rollback cosmos-sdk and tendermint state by one height
  rosetta             spin up a rosetta server
  start               Run the full node
  status              Query remote node for status
  tendermint          Tendermint subcommands
  testnet             subcommands for starting or configuring local testnets
  tx                  Transactions subcommands
  validate-genesis    validates the genesis file at the default location or at the location passed as an arg
  version             Print the application binary version information

Flags:
  -b, --broadcast-mode string    Transaction broadcasting mode (sync|async|block) (default "sync")
      --chain-id string          Specify Chain ID for sending Tx (default "testnet")
      --fees string              Fees to pay along with transaction; eg: 10aphoton
      --from string              Name or address of private key with which to sign
      --gas-adjustment float     adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored  (default 1)
      --gas-prices string        Gas prices to determine the transaction fee (e.g. 10aphoton)
  -h, --help                     help for exrpd
      --home string              directory for config and data (default "/root/.exrpd")
      --keyring-backend string   Select keyring's backend (default "os")
      --log_format string        The logging format (json|plain) (default "plain")
      --log_level string         The logging level (trace|debug|info|warn|error|fatal|panic) (default "info")
      --node string              <host>:<port> to tendermint rpc interface for this chain (default "tcp://localhost:26657")
      --trace                    print out full stack trace on errors

Use "exrpd [command] --help" for more information about a command.

After that, when I ran the command $exrpd config chain-id exrp_1440002-1 in the Initialize Node step, there was no error.

This might make it clearer for newcomers that they need to run exrpd after creating the alias.

Thank you!

Tables too aggressively break code blocks mid-word

The first column in particular, which often contains field names, is too small to fit many of these field names. For example, DiscountedFee gets cut to "Disco / unted / Fee" in this table:

2023-05-01_160512_231409776

This is something that can be improved (to some extent) with CSS. On xrpl.org, the CSS prioritizes not breaking these field names, so the same table would render like this:

2023-05-01_160719_366584588

It seems that the main culprit is the following CSS rule:

code[class="language-text"] {
    overflow-wrap: anywhere;
}

I'm not sure where this rule is coming from originally (it's one of the "inline" style sheets) but it's usually better not to apply that within tables. There are drawbacks to this—if you have really long field names/code lines in a table then it can distort the table or run it off the side—but they're manageable and legibility is generally better without it in my experience.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.