ripcordsoftware / libstringintern Goto Github PK

Great job with this library!

This is just what I need for an open source project I'm working on, but I need serialization support.

Do you have any plans for that or do you accept PRs?

Thanks

In order to prevent strange destruct sequence problems the nursery and catalog should hold shared_ptr and not StringPage*.

The archive should use make_shared() to make the pointers.

Calling StringPagesCatalog.Add() causes the internal counter to increment even if the page could not be added. This could cause overflow eventually which would result in a corrupted catalog.

The -latomic linker command line switch cases build fail on OSX.

Need to sniff the platform as part of the build since -latomic is required on PPC.

The vector<atomic> type is prone to false sharing on high footfall variables like the page offset counters.

StringPagesCatalog.Add() accepts a nullptr StringPage* into the catalog. These pages should be rejected.