rinchsan / device-check-go Goto Github PK

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

• Want to support cancellable (or custom) context.Context for http requests
• Going to be a major release of v2
  • Create /v2 directory and copy existing files to the directory, and then support cancellable context.Context only in /v2 ? (according to the official go documentation)
  • https://blog.golang.org/v2-go-modules
• Pass ctx context.Context as a first argument for query/update/validate methods
  • then pass it to api.do as a first argument

This issue contains a list of Renovate updates and their statuses.

This repository currently has no open or pending branches.

• Check this box to trigger a request for Renovate to run again on this repository

especially for the latest go version

Apple's devicecheck endpoints return errors with both an error code and a response body. Multiple response bodies can be produced for the same error code (see here)*. e.g., 401 can represent an expired token or an invalid token.

The library currently maps each response code to a separate error object (e.g. 401 is mapped to ErrUnauthorized). This means that we cannot tell what the details of the error are. For some errors like 400 that can have many different reasons, this makes debugging challenging.

Proposed solution: instead of mapping response codes to static errors with static strings, create errors by mapping the response codes to an instance of an error type on a per-code basis, with that instance containing the response body string. This allows calling code to continue checking the error type, but preserves the details of the error. Basically, use go 1.13 style errors.

• Apple used to have these response codes in their documentation, but I can't find them now that they've rewritten it for AppAttest...

Hi! I come from an older version of this library which was github.com/snowman-mh/device-check-go and it is redirecting me to this repo now. And I see that the older version was using ErrBitStateNotFound which is missing in this repository. The only trace of this error is found in README and is kind of misleading because the SDK doesn't return this error now:

if err := client.QueryTwoBits("DEVICE_TOKEN_FROM_CLIENT", &result); err != nil {
	// error handling
	// Note that SDK returns ErrBitStateNotFound error if no bits found
}

What would be a suitable replacement for this error in the current version of SDK? I browsed the code and didn't find any. It would be nice to update the README as well.