rimutec / faker Goto Github PK

The resulting ZIP code is always 5 characters, and the last two characters are '#'.

Please find attached a test file which can be integrated (added) to the test solutions and is ready to run, where (nearly) all methods for data generation are called for each supported locale (according to the documentation).

The tests demonstrates where exceptions are happing and unfortunatly there are a lot :-(.
Please don't see this with any anger. I really like and appreciate your effort and the package!

AllLocalizationTests.zip

Describe the bug
Using RimuTec.Faker.Name.LastName() with locale "pl" throws an exception with the following message:

"(Line: 48, Col: 5, Idx: 29115) - (Line: 48, Col: 9, Idx: 29119): Duplicate key"

To Reproduce

1. Create a project that targets .NET Framework 4.6.2 or use the test case with name ""
2. Set Config.Locale = "pl";
3. Call RimuTec.Faker.Name.LastName();

Expected behavior
A last name will be generated instead of the thrown exception.

Additional context
Add any other context about the problem here.

Describe the bug
RimuTec.Faker.Address.StreetAddress() throws an exception when the Locale is set to "ru".

To Reproduce

1. Create a project that targets .NET Framework 4.6.2 or use the test case with name "StreetAddress_With_Default_Values()"
2. Reference RimuTec.Faker (via dll / nuget)
3. Set locale to russian (Config.Locale = "ru";)
4. Call RimuTec.Faker.Address.StreetAddress();

Expected behavior
A street address would be returned, but an exception is thrown.

Additional context
I made the following changes to get it working at the GeneratorBase.cs file:

Line 83
Changed from
return Fetch(fakerNode[locatorParts[0]], locatorParts.Skip(1).ToArray());
To
return Fetch(fakerNode[locatorParts[0].ToLowerInvariant()], locatorParts.Skip(1).ToArray());

Line 98
Changed from
return Fetch(fakerNode[locatorParts[0]], locatorParts.Skip(1).ToArray());
To
return Fetch(fakerNode[locatorParts[0].ToLowerInvariant()], locatorParts.Skip(1).ToArray());