rikkigibson / corvallis-bus-android Goto Github PK

It would be great if the app would remember that time it received an estimated arrival time and correct for the difference in time. Currently if the network is slow it displays an old estimated arrival time for sometimes a very long time, which can make one late fir the bus.

Alternately if the display was converted to an estimated arrival time via addition, and then the displayed value would not become increasingly incorrect as time passes.

This is after the user has given permission.

The null check on selectedStopId should probably be followed by assignment to a local final int which is then referenced in the doInBackground callback.

https://github.com/RikkiGibson/Corvallis-Bus-Android/blob/master/mobile/src/main/java/osu/appclub/corvallisbus/browsestops/StopsFragment.java#L210

There have been some crash reports that indicate getActivity() may be returning null here:

https://github.com/RikkiGibson/Corvallis-Bus-Android/blob/master/mobile/src/main/java/osu/appclub/corvallisbus/favorites/FavoritesFragment.java#L260

StackOverflow seems to suggest saving the Activity in an instance field on the Fragment to work around this.
https://stackoverflow.com/questions/6215239/getactivity-returns-null-in-fragment-function#6225044

It may not be appropriate to show a toast if the fragment is not attached to activity, anyway, though, so a simple null check on the return value of getActivity() would probably be best.

The title bar in the Browse view should probably contain a search bar, kind of like the Gmail app. You should be able to type in part of the name of a bus stop and show a list of matches, then tap to jump to that stop in the map.
https://stackoverflow.com/questions/21585326/implementing-searchview-in-action-bar

This tutorial may be relevant. http://javapapers.com/android/android-searchview-action-bar-tutorial/