Giter Club home page Giter Club logo

tradeskillmaster-cata's Issues

Bug(TradeSkillMaster_Accounting/Data:ScanCollectedMail): bad price per item on AH sale/buy

When with AH sale/buy -- quantity always is 1

this code is wrong

for j = 1, ATTACHMENTS_MAX_RECEIVE do

-- this is done for each mail slot (16 slots), but they are empty (quantity will always be 0 after the loop and 1 afterwards)

it is possible to make a calculation of the quantity within each condition for the auction:

if invoiceType == "seller" and buyer and buyer ~= "" then -- AH Sales
		local quantity = select(3, GetInboxItem(index, 1))
		local daysLeft = select(7, GetInboxHeaderInfo(index))
		local saleTime = (time() + (daysLeft - 30) * SECONDS_PER_DAY)
		local link = select(2, TSMAPI:GetSafeItemInfo(itemName))
		local itemString = TSM.db.global.itemStrings[itemName] or TSMAPI:GetItemString(link)
		if itemString and private:CanLootMailIndex(index) then
			local copper = floor((bid - ahcut) / quantity + 0.5)
			Data:InsertItemSaleRecord(itemString, "Auction", quantity, copper, buyer, saleTime)
		end
elseif invoiceType == "buyer" and buyer and buyer ~= "" then -- AH Buys
		local quantity = select(3, GetInboxItem(index, 1))
		local link = GetInboxItemLink(index, subIndex or 1)
		local itemString = TSMAPI:GetItemString(link)
		if itemString and private:CanLootMailIndex(index) then
			--might as well grab the name for future lookups
			local name = TSMAPI:GetSafeItemInfo(link)
			TSM.db.global.itemStrings[name] = itemString

			local copper = floor(bid / quantity + 0.5)
			local daysLeft = select(7, GetInboxHeaderInfo(index))
			local buyTime = (time() + (daysLeft - 30) * SECONDS_PER_DAY)
			Data:InsertItemBuyRecord(itemString, "Auction", quantity, copper, buyer, buyTime)
		end

for

if invoiceType == "seller" and buyer and buyer ~= "" then -- AH Sales

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.